Do not download non-local binaries #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The way Bazel is meant for this to work (and works with remote execution as well) is via toolchain resolution. See https://github.com/aspect-build/rules_py/blob/main/py/private/toolchain/repo.bzl as an example: the "hub" repo just registers a bunch of |
|
Still not sure I follow how to defer downloads in a repository rule — it seems like even if I create a repository for each of the platforms for each of the tools that I’m going to end up needing a download call in that rule, which ends up largely the same? |
|
I'll try to send the PR for this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, we download all the declared binaries in our lockfile. This can be slow/expensive.
After this PR, we skip downloading any binary that doesn't match the local machine's OS or CPU. We're not users of remote execution, and it's not clear if/how this affects remote execution. If it negatively affects RBE, we can always drop this functionality behind a flag on our repository rules.