-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Onshape provider endpoints are not up to date #469
Comments
Thanks for letting us know @koliyo - I'll look at updating the provider and pushing a new version later today or tomorrow 👍 |
Update the URLs used by the Onshape provider to resolve aspnet-contrib#469.
Update the URLs used by the Onshape provider to resolve #469.
HI @koliyo - an updated version of the package, Would you be able to try it out in your application and verify it resolves your need to override the URLs on the options? Now you should be able to just go back to: .AddOnshape(options => {
IConfigurationSection outhConfig =
Configuration.GetSection("Authentication:Onshape");
options.ClientId = outhConfig["ClientId"];
options.ClientSecret = outhConfig["ClientSecret"];
}) |
Hi @koliyo - were you able to validate the fix for the Onshape provider? |
As you've not provided any feedback I'm going to assume it works. |
This fix is now available in version 3.1.4 of the provider. |
Describe the bug
When using the
AspNet.Security.OAuth.Onshape
provider with the default endpoint values I getinvalid_grant
response.See https://github.com/aspnet-contrib/AspNet.Security.OAuth.Providers/blob/dev/src/AspNet.Security.OAuth.Onshape/OnshapeAuthenticationDefaults.cs
By using these updated endpoint declarations I get proper auth flow:
ie
cad.onshape.com
->oauth.onshape.com
The text was updated successfully, but these errors were encountered: