-
Notifications
You must be signed in to change notification settings - Fork 150
Add a new resource owner password flow sample #98
Conversation
Wooo, thank you very much! 😄 I'll start bombing you with (cool) remarks as soon as possible. |
@@ -2,7 +2,7 @@ | |||
|
|||
<div class="jumbotron"> | |||
@if (User?.Identity?.IsAuthenticated ?? false) { | |||
<h1>Welcome, @User.Identity.Name</h1> | |||
<h1>Hi, @Context.User.Identity.Name</h1> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is Context.
now necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did I change that? Hmm. I wonder when and why.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's not something I changed recently: https://github.com/aspnet-contrib/AspNet.Security.OpenIdConnect.Server/blob/dev/samples/Mvc/Mvc.Client/Views/Shared/Home.cshtml 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I undid it. I'm not sure why I changed it in the first place.
@@ -0,0 +1,8 @@ | |||
p4qYnZxKxntusUtZWayPMGIy1YxxIji6jl0/Nc6WEu/iOhXlCVBId2QPzVQLlFKbJFKE6yb0gQnL2CUY1gZLXrVvAtdn7mla2VJtjDqUHi83D1OnEBvpcdzdNz6DPYGOwa64WBDP0amUAees6uZKdXp6RCb+vN109CE/gW9tbsXxbkjhxMsr9LXCLqpYSwkYZyxXBH/qaV7sCgv3qkNWmsnuAMXE+ztDdVY6zLtXGgkkmrWNk09siFIERgi6QJwOpf93RRc6LQG/HNCwz30sUroVMqACZPJQyQgT2I5HUh2AiTDDKg7kE1maR78+FhvLv/XkVXrwpPVe1f8tJX63wQ== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this ugly thing 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do :) I may have some time for this in the near future, because we've just delivered the two proposals that were taking up all my time.
@@ -0,0 +1,2 @@ | |||
server=Microsoft.AspNet.Server.WebListener |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: you can remove this file and set these options directly in project.json. See the Mvc sample for more info 👍
In the
Indeed the I was a bit puzzled by this as well, however the served document contains the inline script
which solves this mystery. |
Thank you @sunsided. 👍 I added that to the notes. https://github.com/bigfont/AspNet.Security.OpenIdConnect.Server/commit/894ff6c24b755ebd77ccc5a420baaa10675fe699 |
@shaunluttin should I close this PR as discarded? |
Hi Kevin, You can if you like. I may pick it up again in 2016 when work slows down. Best, On Tue, Nov 24, 2015 at 9:12 AM, Kévin Chalet notifications@github.com
|
Closing this PR, as it's targeting the vNext branch, that will be deleted soon. |
This is an additional sample that uses the resource owner password flow.
It will be relevant, for instance, to applications built with AngularJS, which would like to offer authentication/authorization, without needing to rely entirely on external providers.