Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more Docker + ASP.NET Core samples #5450

Open
natemcmaster opened this issue Feb 13, 2018 · 13 comments

Comments

@natemcmaster
Copy link
Contributor

commented Feb 13, 2018

We frequently get asked to build features into our Docker images that are already possible and easy to do without needing changes to the base images.

Instead, we would like to address this by adding more samples and docs for these commonly asked features/questions.

  • How to use multi-stage builds
  • Using NodeJS 9
  • Add NodeJS so JavascriptServices works at runtime
  • Using powershell in Linux images or NanoServer 1709
  • Running tests in docker
  • Writing a Dockerfile to building a solution or multiple .csproj files
  • Debugging remotely into a docker container (vsdbg)

cc @glennc

[Edit - append by @rick-anderson]
Create basic windows/MacOs dev/productions samples using HTTPS from https://github.com/dotnet/dotnet-docker/tree/master/samples

@glennc

This comment has been minimized.

Copy link
Member

commented Feb 13, 2018

What I am thinking here is something akin to a Docker recipes page. Including examples for each of the ones you listed as well as how to do libgdiplus in Docker.

I think we could link to this from the top of our scaffold-ed Dockerfiles.

//cc @richlander

@Rick-Anderson Rick-Anderson added this to the Backlog milestone Feb 14, 2018

@Rick-Anderson

This comment has been minimized.

Copy link
Contributor

commented Feb 14, 2018

//cc @spboyer

@MichaelSimons

This comment has been minimized.

Copy link

commented Feb 28, 2018

Here is an additional request for doc on ASP.NET Core SPA templates - dotnet/dotnet-docker#393

@johnknoop

This comment has been minimized.

Copy link

commented Mar 13, 2018

One use case that I don't even know if it's supported, and at least not documented, is to be able to just recompile the application without needing to rebuild and restart the container. Right now I have to do CTRL+F5 for the entire docker-compose, even if I've just made changes to one of the projects, which results in a very slow feedback cycle. It would be nice to get the same live update experience for compiled code, as I do for static files. Perhaps using dotnet watch, or, failing that, using some post-build script that updates the running container with new binaries or something like that.

@dapalmi

This comment has been minimized.

Copy link

commented May 7, 2018

Ok. Sorry. I thought this is the continuation of this issue

@dapalmi

This comment has been minimized.

Copy link

commented May 7, 2018

@Rick-Anderson The workaround works. Thanks. It just doesn't fit into the otherwise very nicely flowing ASP NET Core workflows. In Visual Studio Angular Templates are offered and you can add Docker support, so me as a normal user would expect this to work without having to google a workaround first

@Rick-Anderson

This comment has been minimized.

Copy link
Contributor

commented May 7, 2018

@dapalmi agreed.
@scottaddie can you work with the PU to get a fwlink on the wizard to warn folks. The fwlink could point an H2 in our Angular doc, which in turn could point to that issue.

@dalibor983

This comment has been minimized.

Copy link

commented Oct 19, 2018

@natemcmaster This is good way to install nodejs in linux based docker image. But there is one issue with docker integration with visual studio because visual studio mount local source in docker container but all native nodejs components (like node sass) are built for windows not for linux 😞

@aspnet aspnet deleted a comment from dapalmi Oct 25, 2018

@Rick-Anderson

This comment has been minimized.

Copy link
Contributor

commented Oct 25, 2018

@natemcmaster @glennc do you have any samples/content we can start with?

@Rick-Anderson Rick-Anderson added the P1 label Oct 25, 2018

@Rick-Anderson

This comment has been minimized.

Copy link
Contributor

commented Jan 15, 2019

@natemcmaster @glennc do you have any samples/content we can start with?

@Rick-Anderson Rick-Anderson added the PU label Jan 15, 2019

@glennc

This comment has been minimized.

Copy link
Member

commented Jan 15, 2019

This might be solved by the work that @richlander has been doing.

@spboyer

This comment has been minimized.

Copy link
Contributor

commented Jan 18, 2019

See https://github.com/dotnet/dotnet-docker
There are well-documented samples in /samples/aspnetapp with README for many scenarios.

@SirwanAfifi

This comment has been minimized.

Copy link

commented Feb 15, 2019

I have the same issue: microsoft/aspnet-docker#164

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
10 participants
You can’t perform that action at this time.