Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change source code and repo license info to .NET Foundation #2

Closed
Eilon opened this issue Jul 23, 2016 · 3 comments
Closed

Change source code and repo license info to .NET Foundation #2

Eilon opened this issue Jul 23, 2016 · 3 comments
Assignees
@dougbu
Labels
3 - Done task
Milestone
3.2.4-preview1

Comments

@Eilon
Copy link
Member

Eilon commented Jul 23, 2016

Change all the .CS files and any other license files in the repo to be the same as ASP.NET Core.
@Eilon Eilon modified the milestone: 5.2.4 Jul 23, 2016
@dougbu
Copy link
Member

dougbu commented Aug 8, 2016

@Eilon please confirm the following assumptions:

  • Should ignore the OData directory tree. It's fine to remove this tree entirely in a subsequent commit.
  • Should not add copyright headers to files in the WebApiHelpPage or WebApiHelpPageVB projects. These are templates for customer projects.
  • Use the following in CommonAssemblyInfo:
#if !BUILD_GENERATED_VERSION
[assembly: AssemblyCompany(".NET Foundation")]
[assembly: AssemblyCopyright("Copyright © .NET Foundation. All rights reserved.")]
#endif

Note the above does not match other Asp Net projects. The following is the norm but looks wrong given our copyright headers.

[assembly: AssemblyCompany("Microsoft Corporation.")]
[assembly: AssemblyCopyright("© Microsoft Corporation. All rights reserved.")]

@dougbu
Copy link
Member

dougbu commented Aug 8, 2016

Also

  • Should not add copyright headers to files matching *.designer.cs or *.generated.cs.

@dougbu dougbu mentioned this issue Aug 9, 2016
Merged
dougbu added a commit that referenced this issue Aug 9, 2016
@dougbu
Change source code and repo license info to .NET Foundation
1a987f8 
- #2
- a few manual changes in `License.txt`, `Settings.StyleCop`, `CommonAssemblyInfo.*`, and
  `tools\src\Microsoft.Web.FxCop\Properties\AssemblyInfo.cs`
@dougbu
Copy link
Member

dougbu commented Aug 9, 2016

1a987f8

@dougbu dougbu closed this as completed Aug 9, 2016
@Eilon Eilon mentioned this issue Feb 8, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dougbu dougbu

Labels
3 - Done task
Projects
None yet
Milestone
3.2.4-preview1
Development

No branches or pull requests
2 participants
@Eilon @dougbu