This repository has been archived by the owner on Nov 20, 2018. It is now read-only.
Update version to servicing to fix SiteExtension build #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Linux builds are failing. Any idea why? |
|
No idea but retry helped. |
natemcmaster
approved these changes
Nov 20, 2018
| <VersionPrefix>2.2.0</VersionPrefix> | ||
| <VersionSuffix>rtm</VersionSuffix> | ||
| <VersionPrefix>2.2.1</VersionPrefix> | ||
| <VersionSuffix>servicing</VersionSuffix> | ||
| <PackageVersion Condition="'$(IsFinalBuild)' == 'true' AND '$(VersionSuffix)' == 'rtm' ">$(VersionPrefix)</PackageVersion> |
There was a problem hiding this comment.
Suggested change
| <PackageVersion Condition="'$(IsFinalBuild)' == 'true' AND '$(VersionSuffix)' == 'rtm' ">$(VersionPrefix)</PackageVersion> | |
| <PackageVersion Condition="'$(IsFinalBuild)' == 'true' AND ('$(VersionSuffix)' == 'rtm' OR AND '$(VersionSuffix)' == 'servicing' ) ">$(VersionPrefix)</PackageVersion> |
| <VersionPrefix>2.2.0</VersionPrefix> | ||
| <VersionSuffix>rtm</VersionSuffix> | ||
| <VersionPrefix>2.2.1</VersionPrefix> | ||
| <VersionSuffix>servicing</VersionSuffix> | ||
| <PackageVersion Condition="'$(IsFinalBuild)' == 'true' AND '$(VersionSuffix)' == 'rtm' ">$(VersionPrefix)</PackageVersion> | ||
| <PackageVersion Condition="'$(IsFinalBuild)' == 'true' AND '$(VersionSuffix)' != 'rtm' ">$(VersionPrefix)-$(VersionSuffix)-final</PackageVersion> |
There was a problem hiding this comment.
Suggested change
| <PackageVersion Condition="'$(IsFinalBuild)' == 'true' AND '$(VersionSuffix)' != 'rtm' ">$(VersionPrefix)-$(VersionSuffix)-final</PackageVersion> | |
| <PackageVersion Condition="'$(IsFinalBuild)' == 'true' AND '$(VersionSuffix)' != 'rtm' AND '$(VersionSuffix)' != 'servicing' ">$(VersionPrefix)-$(VersionSuffix)-final</PackageVersion> |
|
A few tweaks to add to make sure servicing builds produce the right version, but then |
|
This repo has been merged to https://github.com/aspnet/AspNetCore. You'll need to re-open the PR there. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.