Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop disabling all warnings in a few projects #193

Merged
merged 1 commit into from
Mar 11, 2017
Merged

Conversation

dougbu
Copy link
Member

@dougbu dougbu commented Mar 9, 2017

  • add workaround for the ony warning

- add workaround for the ony warning
@dnfclas
Copy link

dnfclas commented Mar 9, 2017

@dougbu,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@@ -4,7 +4,6 @@

<PropertyGroup>
<TargetFramework>netstandard1.6</TargetFramework>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the default

{
add { }
remove { }
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This gets rid of a CS0067 warning for this unused event

@dougbu dougbu merged commit dd3e326 into dev Mar 11, 2017
@dougbu dougbu deleted the dougbu/no.warnings branch March 11, 2017 00:11
@dougbu
Copy link
Member Author

dougbu commented Mar 11, 2017

dd3e326

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants