Add Microsoft.AspNetCore.BuildTools.ApiCheck to builds #205
Commits on Mar 24, 2017
-
Add Microsoft.AspNetCore.BuildTools.ApiCheck to builds
- aspnet/KoreBuild#143 Add Microsoft.AspNetCore.BuildTools.ApiCheck.Task project - include task assembly in the Microsoft.AspNetMicrosoft.AspNetCore.BuildTools.ApiCheck package - add *.props and *.targets files to hook task into `Pack` target; runs just before .nupkg is created - reference Microsoft.AspNetMicrosoft.AspNetCore.BuildTools.ApiCheck project from the Sdk project - requires lots of hacks; dotnet/sdk#939 workarounds fail in this scenario Fall back to `RuntimeTargets` when `RuntimeAssemblies` yields no assemblies Improve project-to-project reference and native assembly handling - avoid `FileNotFoundException` in `AssemblyLoadContext.GetAssemblyName()` due to `\placeholder\` paths - catch and ignore `BadImageFormatException` in `AssemblyLoadContext.GetAssemblyName()` - avoid `InvalidOperationException` in `PackageGraph.RuntimeIsCompatible()` due to missing .sha512 file Change ApiCheck.exe's options and output - add `api-check --compact-output` option - generally make tool's output more useful to the task - catch and log `FileNotFoundException`; output types and stack traces of caught `Exception`s - remove `--framework` option; unused in .NET Framework already - change ApiCheck.exe option from `--ApiListing` to `--api-listing` for consistency w/ other options nits: - remove `PackageGraph.RuntimeIsCompatible()` `candidateRuntime` parameter - not needed and confusingly-named; passed value included in `compatibleRuntimes` - update solution to use current project type GUID - ignore global.json and launchSettings.json - make some Linq a bit more readable - whitespace and `using` cleanup - move all property groups above item groups in Microsoft.AspNetMicrosoft.AspNetCore.BuildTools.ApiCheck.csproj - make a couple of constructors `private`; used only in `public static` methods - ignore case a bit more notes: - don't use `UseCommandProcessor==true`; `ToolTask` writes out .cmd file with a BOM that cmd.exe hates
-
-
Make versions consistent for Microsoft dependencies
- everything should now be using `NETStandard.Library` v1.6.1, CoreFx packages v4.3.0, etc. - remove duplicate `<PropertyGroup>` from `NugetReferenceResolver` project - add two dependencies to `BuildTools.Tasks.Tests` project to avoid package downgrade warnings
-
-
-
-
-
-
-
-
Use Microsoft.Extensions.CommandLineUtils.Sources package
- VersionTool project cannot do this because it has `public` properties of these `internal` types - just sorted the dependencies - will file a separate issue to make those properties `internal` if possible; probably low-pri
-
Use restored
--frameworkoption inApiCheckTask; other cleanup- don't change default: `$(NetStandardImplicitPackageVersion)` -> `$(NetStandardPackageVersion)` - don't use `$(IsPackable)` in a condition; redundant and may block direct use of the `ApiCheck` target
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.