Add Microsoft.AspNetCore.BuildTools.ApiCheck to builds #205
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,3 +19,5 @@ project.lock.json | |
| .build | ||
| .vs/ | ||
| .vscode/ | ||
| global.json | ||
| launchSettings.json | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,4 +11,4 @@ build_script: | |
| clone_depth: 1 | ||
| test: off | ||
| deploy: off | ||
| os: Visual Studio 2017 | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| <!-- | ||
| WARNING: These targets are intended for building Microsoft's ASP.NET Core repos and are not intended | ||
| for use outside of Microsoft. | ||
| --> | ||
| <Project> | ||
| <Target Name="ApiCheck" Condition=" '$(EnableApiCheck)' == 'true' "> | ||
| <PropertyGroup> | ||
| <_ApiListingFileSuffix Condition=" '$(TargetFrameworkIdentifier)' == '.NETFramework' ">net45.json</_ApiListingFileSuffix> | ||
| <_ApiListingFileSuffix Condition=" '$(_ApiListingFileSuffix)' == '' ">netcore.json</_ApiListingFileSuffix> | ||
| <_ApiListingFilePath>$(MSBuildProjectDirectory)\baseline.$(_ApiListingFileSuffix)</_ApiListingFilePath> | ||
| <_ApiExclusionsFilePath>$(MSBuildProjectDirectory)\exceptions.$(_ApiListingFileSuffix)</_ApiExclusionsFilePath> | ||
| <_ApiListingFile Condition=" Exists('$(_ApiListingFilePath)') ">$(_ApiListingFilePath)</_ApiListingFile> | ||
| <_ApiExclusionsFile Condition=" Exists('$(_ApiExclusionsFilePath)') ">$(_ApiExclusionsFilePath)</_ApiExclusionsFile> | ||
| </PropertyGroup> | ||
|
|
||
| <Message Condition=" '$(_ApiListingFile)' != '' " | ||
| Importance="normal" | ||
| Text="Checking for breaking changes in $(MSBuildProjectName), $(TargetFramework)" /> | ||
| <ApiCheckTask Condition=" '$(_ApiListingFile)' != '' " | ||
| ApiListingPath="$(_ApiListingFile)" | ||
|
There was a problem hiding this comment. Could we use the same indentation as C#? Maintaining these indentations over time is just a pain. There was a problem hiding this comment. This is how VS indents XML by default. But, I agree it won't be easy to maintain this in Notepad and VS Code. I am not changing existing indentation to match. There's a random mix in this repo. |
||
| AssemblyPath="$(TargetPath)" | ||
| Framework="$(TargetFramework)" | ||
| ExcludePublicInternalTypes="$(ExcludePublicInternalTypes_InApiCheck)" | ||
| ExclusionsPath="$(_ApiExclusionsFile)" | ||
| ProjetAssetsPath="$(ProjectAssetsFile)" /> | ||
|
|
||
| <Warning Condition=" '$(_ApiListingFile)' == '' " | ||
| Text="No baseline file for $(TargetFramework) found in $(MSBuildProjectName)." /> | ||
| </Target> | ||
| </Project> | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| <!-- | ||
| WARNING: These targets are intended for building Microsoft's ASP.NET Core repos and are not intended | ||
| for use outside of Microsoft. | ||
| --> | ||
| <Project> | ||
| <Target Name="ApiCheck" Condition=" '$(EnableApiCheck)' == 'true' "> | ||
| <ItemGroup> | ||
| <_TargetFrameworks Remove="@(_TargetFrameworks)" /> | ||
| <_TargetFrameworks Include="$(TargetFrameworks)" /> | ||
| </ItemGroup> | ||
|
|
||
| <MSBuild Projects="$(MSBuildProjectFullPath)" | ||
| Targets="ApiCheck" | ||
| Properties="TargetFramework=%(_TargetFrameworks.Identity)" | ||
| RemoveProperties="TargetFrameworks" /> | ||
| </Target> | ||
| </Project> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| <!-- | ||
| WARNING: These targets are intended for building Microsoft's ASP.NET Core repos and are not intended | ||
| for use outside of Microsoft. | ||
| --> | ||
| <Project> | ||
| <PropertyGroup> | ||
| <!-- Temporarily disable API checks in all x-plat runs. Universe builds fail at FileSystem repo. --> | ||
| <EnableApiCheck Condition=" '$(OS)' != 'Windows_NT' ">false</EnableApiCheck> | ||
|
|
||
| <!-- Unconditionally disable API checks if running in .NET Framework MSBuild. Task cannot run there. --> | ||
| <EnableApiCheck Condition=" '$(MSBuildRuntimeType)' != 'Core' ">false</EnableApiCheck> | ||
|
|
||
| <!-- Unconditionally disable API checks if task would use .NET Framework tool x-plat. --> | ||
| <EnableApiCheck Condition=" '$(OS)' != 'Windows_NT' AND $(TargetFramework.StartsWith('net4')) ">false</EnableApiCheck> | ||
|
|
||
| <!-- Unless overridden in the project or in one of the above situations, always do API checks. --> | ||
| <EnableApiCheck Condition=" '$(EnableApiCheck)' == '' ">true</EnableApiCheck> | ||
| <ExcludePublicInternalTypes_InApiCheck Condition=" '$(ExcludePublicInternalTypes_InApiCheck)' == '' ">true</ExcludePublicInternalTypes_InApiCheck> | ||
|
|
||
| <!-- Hook API checks into Pack run, prior to creating the .nupkg but after build (if any). --> | ||
| <GenerateNuspecDependsOn>$(GenerateNuspecDependsOn);ApiCheck</GenerateNuspecDependsOn> | ||
| </PropertyGroup> | ||
| </Project> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you reverse this? VS probably changed it, but the FAE04EC0 guid is correct. This VS bug is being tracked here: dotnet/project-system#1821
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙈 Not a fan of fighting Visual Studio. We can revert this part of the change when dotnet/project-system#1821 is fixed or wait for a future VS update to change the solution for us.