This repository has been archived by the owner on Nov 20, 2018. It is now read-only.
Fix null ref exception when referencing csproj #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -48,7 +48,11 @@ public Project(ProjectModel.Project runtimeProject) | |||
| if (File.Exists(projectLockJsonPath)) | |||
| { | |||
| var lockFile = LockFileReader.Read(projectLockJsonPath, designTime: false); | |||
| ProjectDependencies = lockFile.ProjectLibraries.Select(dep => GetProjectRelativeFullPath(dep.Path)).ToList(); | |||
| ProjectDependencies = lockFile.ProjectLibraries | |||
There was a problem hiding this comment.
do you need to select twice?
|
Is this a feature we will be enabling in the future? |
|
Nope. It's not possible. For an xproj, a csproj is just a dll. It has no notion of where it came from |
|
|
victorhurdugaci
force-pushed
the
victorhu/csproj-refs
branch
from
2c1bd3a
to
c769d8d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #136
The issue is that for xproj files we don't have a project path even though they appear as project references. The fix is to ignore those projects. The consequence is that dotnet watch will not restart the app when code files change in csproj files.
Please review @BrennanConroy