Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update external dependencies to latest GA releases #17482

Closed
ajcvickers opened this issue Aug 28, 2019 · 18 comments · Fixed by #17967
Closed

Update external dependencies to latest GA releases #17482

ajcvickers opened this issue Aug 28, 2019 · 18 comments · Fixed by #17967
Assignees
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone

Comments

@ajcvickers
Copy link
Member

ajcvickers commented Aug 28, 2019

@ajcvickers
Copy link
Member Author

ajcvickers commented Aug 28, 2019

/cc @AndriySvyryd for Cosmos
@bricelam Can you take a look at the other two?

(We don't necessarily have to update, but if there are newer RTM packages we might want to update.)

Thanks @JunTaoLuo for identifying these

@ajcvickers
Copy link
Member Author

/cc @Pilchie FYI

@AndriySvyryd
Copy link
Member

@ajcvickers
Copy link
Member Author

@AndriySvyryd Right, but there is a 3.1.1 package now.

@AndriySvyryd
Copy link
Member

I'm not sure we should upgrade unless we need to, users can always bump it up manually.

@ajcvickers
Copy link
Member Author

@AndriySvyryd Can you try to find out what they fixed between 3.0 and 3.1.1? There might be critical issues that we should update for.

@bricelam
Copy link
Contributor

System.Threading.Tasks.Extensions is for downlevel ValueTask. We can dump it.

@JunTaoLuo JunTaoLuo added this to the 3.0.0 milestone Aug 28, 2019
@ajcvickers
Copy link
Member Author

@bricelam Is it breaking to remove the reference in 3.1, or would it be a no-op anyway?

@bricelam
Copy link
Contributor

The current package actually looks like it will break .NET Standard 2.1 projects. We should remove it in 3.0

@AndriySvyryd
Copy link
Member

AndriySvyryd commented Aug 28, 2019

Here's the changelog: https://github.com/Azure/azure-cosmos-dotnet-v3/blob/releases/3.1.1/changelog.md
I think the only fix our users would benefit from is not using the current culture

@ajcvickers
Copy link
Member Author

@AndriySvyryd Thanks. Given where we are, I agree we stay with 3.0 here. Test coverage is not as good as for other providers.
@bricelam Thanks. We should do an ask-mode PR for this.

@ajcvickers
Copy link
Member Author

@bricelam Looks like our Castle.Core is quite old; given that it only impacts proxies and test coverage is pretty good I think we should update this for 3.0 as well. Thoughts?

@ajcvickers
Copy link
Member Author

@bricelam So you think we should or should not update our Castle reference?

@bricelam
Copy link
Contributor

Oh, lol. Either way--it's low risk and low value. 😉

@ajcvickers
Copy link
Member Author

ajcvickers commented Aug 28, 2019

@bricelam I read through the release notes in more detail. Let's leave as is for now, but we should update for 3.1 or at the latest 5.0the version after 3.1.

@ajcvickers ajcvickers changed the title Consider updating dependencies for 3.0 Consider updating external dependencies to latest GA releases Aug 29, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.1.0 Aug 29, 2019
@ajcvickers ajcvickers changed the title Consider updating external dependencies to latest GA releases Update external dependencies to latest GA releases Aug 30, 2019
@bricelam
Copy link
Contributor

bricelam commented Sep 4, 2019

Our analyzer depends on Microsoft.CodeAnalysis.CSharp.Workspaces. Is it safe to update this package? We really only need to work with the version of Roslyn that ships in VS2019 16.3 and the .NET Core 3.0 SDK, right? (3.3.0)

@bricelam
Copy link
Contributor

bricelam commented Sep 4, 2019

Filed #17625

@bricelam bricelam added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Sep 20, 2019
@ajcvickers ajcvickers modified the milestones: 3.1.0, 3.1.0-preview2 Oct 24, 2019
@ajcvickers ajcvickers modified the milestones: 3.1.0-preview2, 3.1.0 Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants