Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EFCore.Analyzer #17625

Closed
bricelam opened this issue Sep 4, 2019 · 1 comment · Fixed by #17967
Closed

Update EFCore.Analyzer #17625

bricelam opened this issue Sep 4, 2019 · 1 comment · Fixed by #17967
Assignees
@bricelam @roji
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
3.1.0

Comments

@bricelam
Copy link
Contributor

bricelam commented Sep 4, 2019 •
edited

Two concerns:

  1. Can we update Microsoft.CodeAnalysis.CSharp.Workspaces? Will this break compatibility with certain SDK/VS versions? How high can we go? (EF Core 3 requires at least VS 16.3 or the 3.0 SDK)
  2. Newer packages will require us to change from .NET Standard 1.3 to 2.0. This isn't actually breaking, is it?
@bricelam bricelam mentioned this issue Sep 4, 2019
Closed
@bricelam
Copy link
Contributor Author

bricelam commented Sep 4, 2019

Compiler warnings as errors on the newest version:

InternalUsageDiagnosticAnalyzer.cs(40,57): error RS1025: Configure generated code analysis
InternalUsageDiagnosticAnalyzer.cs(57,28): error RS1024: Compare symbols correctly
InternalUsageDiagnosticAnalyzer.cs(82,28): error RS1024: Compare symbols correctly
InternalUsageDiagnosticAnalyzer.cs(106,28): error RS1024: Compare symbols correctly

@ajcvickers ajcvickers added this to the 3.1.0 milestone Sep 6, 2019
@bricelam bricelam added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Sep 20, 2019
@bricelam bricelam mentioned this issue Sep 20, 2019
Merged
@ajcvickers ajcvickers modified the milestones: 3.1.0, 3.1.0-preview2 Oct 24, 2019
@ajcvickers ajcvickers modified the milestones: 3.1.0-preview2, 3.1.0 Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bricelam bricelam

@roji roji

Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
3.1.0
Development

Successfully merging a pull request may close this issue.

Update packages
3 participants
@bricelam @ajcvickers @roji