Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update packages #17967

Merged
merged 1 commit into from
Sep 30, 2019
Merged

Update packages #17967

merged 1 commit into from
Sep 30, 2019

Conversation

bricelam
Copy link
Contributor

Fixes #17482, fixes #17625

@@ -45,6 +45,7 @@ public override void Initialize(AnalysisContext context)
SyntaxKind.SimpleMemberAccessExpression,
SyntaxKind.ObjectCreationExpression,
SyntaxKind.ClassDeclaration);
context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.None);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@roji I don't know what constitutes "generated code", but it doesn't sound important to run our analyzer there, right?

Copy link
Member

@roji roji Sep 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't aware of this... Any idea what constitutes generated code for roslyn?

In any case, I agree it doesn't sound important, but shouldn't we leave whatever the default behavior is? In other words, are all analyzers now supposed to explicitly disable themselves for generated code, and if not, how are we special? Also are there any actual issues with leaving the default behavior?

Copy link
Contributor Author

@bricelam bricelam Sep 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could just suppress the warning. I think the idea behind the analyzer is to make more analyzers think about it and be explicit. They may be thinking about changing the default in a future release

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, didn't realize this was an analyzer warning. I guess it makes sense to do what it says then...

<SQLitePCLRawBundleESqlite3PackageVersion>2.0.1</SQLitePCLRawBundleESqlite3PackageVersion>
<SQLitePCLRawBundleESqlcipherPackageVersion>2.0.1</SQLitePCLRawBundleESqlcipherPackageVersion>
<SQLitePCLRawCorePackageVersion>2.0.1</SQLitePCLRawCorePackageVersion>
<StyleCopAnalyzersPackageVersion>1.1.118</StyleCopAnalyzersPackageVersion>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please confirm all of these new versions are OSS-approved. @Pilchie will be back on Monday and @divega may have the info today if necessary.

Copy link
Member

@AndriySvyryd AndriySvyryd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't repro the Cosmos failures locally, if they continue, try using an older version

@bricelam
Copy link
Contributor Author

bricelam commented Sep 24, 2019

@AndriySvyryd It failed again.

System.InvalidOperationException: Delete database failed. Status code: Unauthorized. Message: 'The input authorization token can't serve the request. Please check that the expected payload is built as per the protocol, and check the key being used. Server used the following payload to sign: 'gettue, 24 sep 2019 16:01:24 gmt'ActivityId: 20370510-e924-4a37-9a37-6ca2becd62e9, Microsoft.Azure.Documents.Common/2.5.1, Darwin/10.13 cosmos-netstandard-sdk/3.2.1'
   at Microsoft.EntityFrameworkCore.Cosmos.Storage.Internal.CosmosClientWrapper.DeleteDatabaseOnceAsync(DbContext _, Object __, CancellationToken cancellationToken) in /_/src/EFCore.Cosmos/Storage/Internal/CosmosClientWrapper.cs:line 194
   at Microsoft.EntityFrameworkCore.Cosmos.Storage.Internal.CosmosClientWrapper.DeleteDatabaseOnce(DbContext context, Object state) in /_/src/EFCore.Cosmos/Storage/Internal/CosmosClientWrapper.cs:line 160
   at Microsoft.EntityFrameworkCore.Storage.ExecutionStrategy.ExecuteImplementation[TState,TResult](Func`3 operation, Func`3 verifySucceeded, TState state) in /_/src/EFCore/Storage/ExecutionStrategy.cs:line 173
   at Microsoft.EntityFrameworkCore.Storage.ExecutionStrategy.Execute[TState,TResult](TState state, Func`3 operation, Func`3 verifySucceeded) in /_/src/EFCore/Storage/ExecutionStrategy.cs:line 159
   at Microsoft.EntityFrameworkCore.Cosmos.Storage.Internal.CosmosClientWrapper.DeleteDatabase() in /_/src/EFCore.Cosmos/Storage/Internal/CosmosClientWrapper.cs:line 149
   at Microsoft.EntityFrameworkCore.Cosmos.Storage.Internal.CosmosDatabaseCreator.EnsureDeleted() in /_/src/EFCore.Cosmos/Storage/Internal/CosmosDatabaseCreator.cs:line 128
   at Microsoft.EntityFrameworkCore.Infrastructure.DatabaseFacade.EnsureDeleted() in /_/src/EFCore/Infrastructure/DatabaseFacade.cs:line 91
   at Microsoft.EntityFrameworkCore.Cosmos.TestUtilities.CosmosTestStore.Clean(DbContext context) in /_/test/EFCore.Cosmos.FunctionalTests/TestUtilities/CosmosTestStore.cs:line 146
   at Microsoft.EntityFrameworkCore.TestUtilities.TestStore.Initialize(Func`1 createContext, Action`1 seed, Action`1 clean) in /_/test/EFCore.Specification.Tests/TestUtilities/TestStore.cs:line 78
   at Microsoft.EntityFrameworkCore.Cosmos.TestUtilities.CosmosTestStore.Initialize(Func`1 createContext, Action`1 seed, Action`1 clean) in /_/test/EFCore.Cosmos.FunctionalTests/TestUtilities/CosmosTestStore.cs:line 81
   at Microsoft.EntityFrameworkCore.TestUtilities.TestStore.Initialize(IServiceProvider serviceProvider, Func`1 createContext, Action`1 seed, Action`1 clean) in /_/test/EFCore.Specification.Tests/TestUtilities/TestStore.cs:line 48
   at Microsoft.EntityFrameworkCore.Cosmos.TestUtilities.CosmosTestStore.CreateInitialized(String name, Action`1 extensionConfiguration) in /_/test/EFCore.Cosmos.FunctionalTests/TestUtilities/CosmosTestStore.cs:line 27
   at Microsoft.EntityFrameworkCore.Cosmos.TestUtilities.CosmosDbConfiguredConditionAttribute.TryConnectAsync() in /_/test/EFCore.Cosmos.FunctionalTests/TestUtilities/CosmosDbConfiguredConditionAttribute.cs:line 34
   at Microsoft.EntityFrameworkCore.Cosmos.TestUtilities.CosmosDbConfiguredConditionAttribute.TryConnectAsync() in /_/test/EFCore.Cosmos.FunctionalTests/TestUtilities/CosmosDbConfiguredConditionAttribute.cs:line 60
   at Microsoft.EntityFrameworkCore.Cosmos.TestUtilities.CosmosDbConfiguredConditionAttribute.IsMetAsync() in /_/test/EFCore.Cosmos.FunctionalTests/TestUtilities/CosmosDbConfiguredConditionAttribute.cs:line 23

@bricelam
Copy link
Contributor Author

Version 3.1.1 of Microsoft.Azure.Cosmos seems to work. @AndriySvyryd do you wan to investigate and submit an issue? It only seems to affect Linux and macOS

@smitpatel
Copy link
Member

@bricelam - Let's file an issue. (@AndriySvyryd is on vacation)

@bricelam
Copy link
Contributor Author

bricelam commented Sep 24, 2019

Filed Azure/azure-cosmos-dotnet-v3#847

@AndriySvyryd
Copy link
Member

My commit is in, please rebase

@bricelam bricelam merged commit 68b864c into dotnet:release/3.1 Sep 30, 2019
@bricelam bricelam deleted the up branch September 30, 2019 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update EFCore.Analyzer Update external dependencies to latest GA releases
5 participants