-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update packages #17967
Update packages #17967
Conversation
@@ -45,6 +45,7 @@ public override void Initialize(AnalysisContext context) | |||
SyntaxKind.SimpleMemberAccessExpression, | |||
SyntaxKind.ObjectCreationExpression, | |||
SyntaxKind.ClassDeclaration); | |||
context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.None); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@roji I don't know what constitutes "generated code", but it doesn't sound important to run our analyzer there, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wasn't aware of this... Any idea what constitutes generated code for roslyn?
In any case, I agree it doesn't sound important, but shouldn't we leave whatever the default behavior is? In other words, are all analyzers now supposed to explicitly disable themselves for generated code, and if not, how are we special? Also are there any actual issues with leaving the default behavior?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could just suppress the warning. I think the idea behind the analyzer is to make more analyzers think about it and be explicit. They may be thinking about changing the default in a future release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, didn't realize this was an analyzer warning. I guess it makes sense to do what it says then...
<SQLitePCLRawBundleESqlite3PackageVersion>2.0.1</SQLitePCLRawBundleESqlite3PackageVersion> | ||
<SQLitePCLRawBundleESqlcipherPackageVersion>2.0.1</SQLitePCLRawBundleESqlcipherPackageVersion> | ||
<SQLitePCLRawCorePackageVersion>2.0.1</SQLitePCLRawCorePackageVersion> | ||
<StyleCopAnalyzersPackageVersion>1.1.118</StyleCopAnalyzersPackageVersion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't repro the Cosmos failures locally, if they continue, try using an older version
@AndriySvyryd It failed again.
|
Version 3.1.1 of Microsoft.Azure.Cosmos seems to work. @AndriySvyryd do you wan to investigate and submit an issue? It only seems to affect Linux and macOS |
@bricelam - Let's file an issue. (@AndriySvyryd is on vacation) |
My commit is in, please rebase |
Fixes #17482, fixes #17625