This repository has been archived by the owner on Nov 20, 2018. It is now read-only.
Lazy init FeatureReferences #925
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidfowl
reviewed
Nov 9, 2017
| @@ -8,5 +8,65 @@ | |||
| "TypeId": "public class Microsoft.AspNetCore.Http.HttpContextFactory : Microsoft.AspNetCore.Http.IHttpContextFactory", | |||
| "MemberId": "public .ctor(Microsoft.Extensions.ObjectPool.ObjectPoolProvider poolProvider, Microsoft.Extensions.Options.IOptions<Microsoft.AspNetCore.Http.Features.FormOptions> formOptions, Microsoft.AspNetCore.Http.IHttpContextAccessor httpContextAccessor)", | |||
| "Kind": "Removal" | |||
| }, | |||
| { | |||
| "TypeId": "public class Microsoft.AspNetCore.Http.DefaultHttpContext : Microsoft.AspNetCore.Http.HttpContext", | |||
There was a problem hiding this comment.
@benaadams We can't make breaking changes in a minor update.
|
@benaadams This introduces breaking changes. Do you have something that doesn't break APIs? |
|
@benaadams Closing this out. I think we need to find an approach that doesn't break things. Maybe we write a different HttpContext implementation that does this instead of changing the default. |
|
Non-breaking #999 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #814 "Improve DefaultHttpXxx default paths"
Fixes #924 "FeatureCache is over-checked and over-reset"
The Context feature cache is checked and initializes the Response and Request caches at the point one is accessed, so the version check via interface (and sum through collection counts) is shared; and the FeatureReferences structs are only initialized once.
It cuts the version checks from 7 to 5; and the cache initialization to 2x Context, 1x Request, 1x Response, so down 2.
Pre
Post
The early init of the FormFeature triggered the access of the HttpRequest and caused initalization; so I had to move that to be on demand - so it also resolves:
Fixes #677 "FormFeature allocates when unused"
Fixes #880 "Don't allocate the FormFeature eagerly per request"
Also
Sealed and made concrete the
DefaultHttpRequestandDefaultHttpResponseclass/references for devirtualization and made their initialization/uninitialization simpler.Someone can always inherit from
HttpContext/HttpRequest/HttpResponseif they want a non-Default.However it doesn't preclude alternative uses. As an example, reimplemented the
PooledHttpContextsample by composing withDefaultHttpContextrather than via inheritance./cc @davidfowl @muratg @vancem @Tratcher @HaoK