Skip to content
This repository has been archived by the owner on Dec 20, 2018. It is now read-only.

Replace SignIn with RefreshSignIn in UI #1616

Closed
jbagga opened this issue Feb 5, 2018 · 4 comments
Closed

Replace SignIn with RefreshSignIn in UI #1616

jbagga opened this issue Feb 5, 2018 · 4 comments
Assignees
@jbagga
Labels
3 - Done bug cost: S Will take up to 2 days to complete
Milestone
2.1.0-preview2

Comments

@jbagga
Copy link
Contributor

jbagga commented Feb 5, 2018

Manage actions lose cookie info (persistent/external login claim) when they call SignInAsync instead of RefreshSignIn

See #1615 (comment)

cc @HaoK
@jbagga jbagga mentioned this issue Feb 5, 2018
Merged
@HaoK
Copy link
Member

HaoK commented Feb 5, 2018

Cool, are you planning on fixing this @jbagga ?

@jbagga
Copy link
Contributor Author

jbagga commented Feb 7, 2018

I'll let it be triaged first. @Eilon

@Eilon Eilon added this to the 2.1.0-preview2 milestone Feb 7, 2018
@Eilon
Copy link
Member

Eilon commented Feb 7, 2018

Yeah seems like a good idea.

@jbagga jbagga mentioned this issue Mar 2, 2018
Merged
@jbagga jbagga added the cost: S Will take up to 2 days to complete label Mar 14, 2018
@jbagga
Copy link
Contributor Author

jbagga commented Mar 14, 2018

Assigning cost: S as I expect to wrap this up within a day or two.

jbagga added a commit that referenced this issue Mar 16, 2018
@jbagga
Use RefreshSignInAsync (#1655)
641dfe3 
Addresses #1616
@jbagga jbagga closed this as completed Mar 16, 2018
@dougbu dougbu mentioned this issue Apr 9, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jbagga jbagga

Labels
3 - Done bug cost: S Will take up to 2 days to complete
Projects
None yet
Milestone
2.1.0-preview2
Development

No branches or pull requests
3 participants
@Eilon @jbagga @HaoK