Skip to content
This repository has been archived by the owner on Apr 8, 2020. It is now read-only.

shrinkwrap error with peerDependencies wp version #1126

Closed
wants to merge 1 commit into from
Closed

shrinkwrap error with peerDependencies wp version #1126

wants to merge 1 commit into from

Conversation

software-engineering
Copy link

Summary of the changes (Less than 80 chars)

  • Add peer dependency for webpack: "^3.3.0", fix npm shrinkwrap problem with newer webpack version

@senritsu
Copy link

any ETA on this? We have a probably related issue with a webpack plugin.

@theCuriousOne
Copy link

theCuriousOne commented Sep 1, 2017

Can you also do an upgrade on the "aspnet-webpack-react" package?

@senritsu
Copy link

senritsu commented Oct 5, 2017

is there any progress on this matter?

@dvdgutzmann
Copy link

We also need this change implemented. Any ETA or reason for not merging the PR?
Keep up the good work and thank for being awesome again, Microsoft!

@MovGP0
Copy link

MovGP0 commented Dec 15, 2017

This is still not solved. I get the error

aspnet-webpack@2.0.1" has incorrect peer dependency "webpack@^1.13.2 || ^2.1.0-beta".

current version is webpack@3.10.0.

@SteveSandersonMS
Copy link
Member

This change was also covered by another PR that was just merged: 0d83504

Thanks for submitting it originally!

@geirsagberg
Copy link
Contributor

What about webpack 4, is it compatible? Might as well add that too, then?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants