Skip to content
This repository has been archived by the owner on Nov 15, 2018. It is now read-only.

Reorganize tests and remove redundant integration tests #105

Closed
5 tasks done
jbagga opened this issue Aug 24, 2017 · 3 comments
Closed
5 tasks done

Reorganize tests and remove redundant integration tests #105

jbagga opened this issue Aug 24, 2017 · 3 comments
Assignees

Comments

@jbagga
Copy link
Contributor

jbagga commented Aug 24, 2017

The tests are organized in a confusing structure and not as we usually organize them. There are a lot of redundant integration tests and some adapters lack unit tests.

1. This test suite can be used to ensure we are spec compliant. It can either be used to generate test code or parsed and tested.

  • 2. This folder has lots of integration tests for all operations (we should remove redundancy)
  • 3. Add integration tests for "Test" operation
  • 4. Clean up test object model classes - simplify by adding them to test classes that use them
  • 5. Ensure all test classes follow the Arrange, Act, Assert pattern; variable names are coherent/sensible (replace patchDoc with patchDocument, obj with object/targetObject etc.), remove unnecessary serialization and formatting of error messages
  • 6. ExpandoObjectAdapter and PocoAdapter do not have unit tests

This PR adds a new adapter called DynamicObjectAdapter with unit tests and integration tests in a folder called IntegrationTests.

cc @rynowak

@Eilon Eilon added this to the 2.1.0 milestone Aug 24, 2017
@jbagga
Copy link
Contributor Author

jbagga commented Oct 19, 2017

ExpandoObjectAdapter was combined with DictionaryAdapter, so now it has unit tests. See this

PocoAdapter unit tests were added here

@jbagga
Copy link
Contributor Author

jbagga commented Oct 23, 2017

PR #117 cover 2., 3. 4. and 5.

@jbagga
Copy link
Contributor Author

jbagga commented Oct 25, 2017

Shelving 1. for now. See #121

jbagga added a commit that referenced this issue Oct 26, 2017
@jbagga jbagga closed this as completed Oct 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants