This repository has been archived by the owner on Dec 18, 2018. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uncaught test failure while I was working on #1218.
In
OnStartingCallbacksAreCalledInLastInFirstOutOrder
andOnCompletedCallbacksAreCalledInLastInFirstOutOrder
, we need to wait externally for all callbacks to be called.Previously this worked fine because by the time we received the FIN from Kestrel, we could be sure those callbacks had been called, since the connection shut down gracefully. Now, however, the client FIN aborts the request, and depending on the timing and the order that things run, the test might see the connection being closed by the server before
OnStarting
/OnCompleted
callbacks were called (because the abort runs concurrent to request processing).@halter73 @natemcmaster