This repository has been archived by the owner on May 21, 2019. It is now read-only.
Assert that OSX >= 10.12 on install #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natemcmaster
changed the title
BrennanConroy
approved these changes
Mar 21, 2017
moozzyk
reviewed
Mar 21, 2017
| @@ -118,6 +118,15 @@ fi | |||
|
|
|||
| if [ "$(uname)" == "Darwin" ]; then | |||
| ulimit -n 2048 | |||
|
|
|||
| # Check that OS is 10.12 or newer | |||
| osx_version="$(sw_vers | grep ProductVersion | awk '{print $2}')" | |||
There was a problem hiding this comment.
Can't you just grep against something like ProductVersion +10\.1[2-9](\.d+)? - if found you are good otherwise you exit ?
There was a problem hiding this comment.
It could, but then I'd have to add a second call to sw_vers and grep to fetch the version for the error message
natemcmaster
force-pushed
the
namc/sierra
branch
from
d68fd6c
to
734e1a1
Compare
|
⌚ this is going to break most of our OSX builds. Before we do this, I'm going to update our travis.yml files to use mac OS Sierra. |
|
Merging now that Travis agents have been updated and internal agents upgrade is in-progress. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.NET Core 2.0 requires macOS Sierra. This adds a check so KoreBuild will fail early if the OS is too old.