Detect OS using DNX #123
Detect OS using DNX #123
Conversation
|
Hmm, we may want to wait for those "other major issues" to be fixed before reacting to anything locally in our repository. Is OSX still more or less broken after this change? Does it make things more usable on Linux at least? |
|
It makes it more usable on Linux. And in theory, the blocking issues I am seeing now shouldn't require more code changes. |
|
Also, this actually works on beta7 on OS X |
| { | ||
| return; | ||
| } | ||
| #endif |
There was a problem hiding this comment.
I think this code should stay. When DNX finishes implementing the runtime artifacts feature, it should start working correctly. The code in NativeLibraryLoader for dnx451 & dnxcore50 will also be removed when that happens.
There was a problem hiding this comment.
I still think we should remove it as the "System.Runtime.InteropServices.RuntimeInformation" package is fickle. As of yesterday, our CI feed publishes a Windows version. At other times, our CI have contained the Linux version. I don't want CI to break this code.
This may change if we unpublish System.Runtime.InteropServices.RuntimeInformation altogether because I believe this publication is actually a mistake in our CI settings.
There was a problem hiding this comment.
I suppose we can defer until #128...
|
|
Workaround aspnet/dnx#2594.
Fixes #121
The code is right and should work, but cannot verify on OS X until DNX fixes other major issues with osx/coreclr.