DNX on OSX/Linux loads the wrong System.Runtime.InteropServices.RuntimeInformation package

[natemcmaster]

System.Runtime.InteropServices.RuntimeInformation.IsPlatform(OSPlatform.Windows) always returns true, even on OSX and Linux.

Repro
Run this on different platforms. It will always print "Windows".

{
    "dependencies": {},
    "frameworks": {
        "dnxcore50":{
            "dependencies": {
                "System.Console":"4.0.0-*",
                "System.Runtime.InteropServices.RuntimeInformation": "4.0.0-*"
            }
        }
    }
}

using System;
using System.Runtime.InteropServices;

namespace Test
{
    public class Program
    {
        public void Main(string[] args)
        {
            if(RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
            {
                Console.WriteLine("Windows");
            }
            if(RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
            {
                Console.WriteLine("Darwin");
            }
            if(RuntimeInformation.IsOSPlatform(OSPlatform.Linux))
            {
                Console.WriteLine("Linux");
            }
        }
    }
}

Versions

1.0.0-beta8-15545    coreclr x64  darwin       
and
1.0.0-beta8-15545    coreclr x64  linux      

System.Runtime.InteropServices.RuntimeInformation 4.0.0-beta-23231

Pulling from https://www.myget.org/F/aspnetlitedev/api/v2

This is related to #2387. Our myget feed publishes a package of System.Runtime.InteropServices.RuntimeInformation that includes the Windows version of the dll. This gets loaded at runtime, and thus misinforms the IsPlatform API about which OS is actually running.

[natemcmaster]

/cc @BrennanConroy

[muratg]

@anurse @moozzyk @BrennanConroy

Any ideas on this one guys?

[moozzyk]

We don't own System.Runtime.InteropServices.RuntimeInformation don't we? It's probably on CoreClr. We have IRuntimeEnvironment.

[BrennanConroy]

Ya, this is because the dll in the nupkg was windows specific.

[BrennanConroy]

Later versions of this package have a runtime.json with osx and Linux targets defined

[muratg]

@BrennanConroy So is this fixed now?

[BrennanConroy]

It might be once Coherence passes.

[muratg]

@BrennanConroy Please test this once we have Coherence.

[analogrelay]

This will still be broken after Coherence, it looks like the runtime.json for it refers to osx (version-less) but we fallback directly from osx.10.10 to unix. Instead we should fall through osx. @BrennanConroy or I can fix that fairly easily.

[analogrelay]

The same should probably be done for ubuntu.14.04 -> ubuntu

[BrennanConroy]

Should also update the NetCore.Platforms list too

[analogrelay]

I'll take this and also ping the necessary folks about updating that package.