This repository has been archived by the owner on May 29, 2019. It is now read-only.
Update MusicStore test projects to use netcoreapp3.0 #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tratcher
suggested changes
Oct 30, 2018
|
🆙 📅 |
Tratcher
approved these changes
Oct 31, 2018
| @@ -34,7 +34,7 @@ public async Task DefaultLocation_Kestrel() | |||
| EnvironmentName = "SocialTesting", | |||
| PublishApplicationBeforeDeployment = true, | |||
| PreservePublishedApplicationForDebugging = Helpers.PreservePublishedApplicationForDebugging, | |||
| TargetFramework = Tfm.NetCoreApp20, // There's only a Store on 2.0 | |||
| TargetFramework = Tfm.NetCoreApp30, | |||
There was a problem hiding this comment.
This scenario is not relevant on 3.0 and is already disabled, do not update it. Remove it instead?
There was a problem hiding this comment.
Yes, the test is stale in that it refers to the runtime store, but I'd rather keep the test and update it to test the shared runtime since the behavior it asserts here is the same with the shared framework. I'll open an issue to update MusicStore tests to test the shared framework.
There was a problem hiding this comment.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React to dotnet/aspnetcore#3761 and dotnet/aspnetcore#3753