This repository has been archived by the owner on Dec 14, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
ScriptTagHelper support for file globbing patterns in src #1577
Comments
@DamianEdwards could you add a few details on how this enhancement would interact w/ Gulp and the #1576 enhancement? For example would Gulp generate And should the generated scripts for #1576 also support globbing? If yes, does the primary source contain the globs while the fallback specifies only a different root URI? |
@dougbu Yes, it's expected Grunt/Gulp would be used to generate Here's a full example using both features: <environment name="Development">
<script src="~/lib/jquery/jquery.js"></script>
<script src="~/lib/jquery-validation/jquery.validate.js"></script>
<script asp-src-include="js/**/*.js" asp-src-exclude="*.min.js"></script>
</environment>
<environment names="Staging,Production">
<script src="http://ajax.aspnetcdn.com/ajax/jQuery/jquery-2.1.1.min.js"
asp-fallback-src="~/lib/jquery/jquery.min.js"
asp-fallback-test="window.jquery"></script>
<script src="http://ajax.aspnetcdn.com/ajax/jquery.validate/1.13.1/jquery.validate.min.js"
asp-fallback-src="~/lib/jquery-validation/jquery.validate.min.js"
asp-fallback-test="window.jquery && window.jquery.validate"></script>
<script asp-src="~/js/site.min.js"></script>
</environment> |
Should this be just part of the script tag feature design (which we didn't quite do yet)? I like the pattern, I just want to keep the issue count under check. |
Never mind, just noticed you made it go to RC rather than Beta2 |
DamianEdwards
added a commit
that referenced
this issue
Feb 25, 2015
DamianEdwards
added a commit
that referenced
this issue
Feb 25, 2015
DamianEdwards
added a commit
that referenced
this issue
Feb 26, 2015
DamianEdwards
added a commit
that referenced
this issue
Feb 26, 2015
DamianEdwards
added a commit
that referenced
this issue
Feb 26, 2015
DamianEdwards
added a commit
that referenced
this issue
Feb 26, 2015
DamianEdwards
added a commit
that referenced
this issue
Feb 26, 2015
DamianEdwards
added a commit
that referenced
this issue
Feb 26, 2015
DamianEdwards
added a commit
that referenced
this issue
Feb 26, 2015
DamianEdwards
added a commit
that referenced
this issue
Feb 26, 2015
DamianEdwards
added a commit
that referenced
this issue
Feb 26, 2015
DamianEdwards
added a commit
that referenced
this issue
Feb 26, 2015
DamianEdwards
added a commit
that referenced
this issue
Feb 26, 2015
DamianEdwards
added a commit
that referenced
this issue
Feb 27, 2015
Fixed in 8b64e3c |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The
ScriptTagHelper
should support file globbing patterns via theasp-src
attribute as a way to indicate that multiple script tags should be rendered. This simplifies the management of script references during development when used in conjunction with the proposedEnvironmentTagHelper
and a task runner such as Gulp for doing script bundling & minification.e.g.
The text was updated successfully, but these errors were encountered: