Add overload to AddControllerAsServices that uses the default controller discovery logic

[davidfowl]

It should use the default controller discovery logic baked into these

Mvc/src/Microsoft.AspNetCore.Mvc.Core/DependencyInjection/MvcCoreServiceCollectionExtensions.cs

Lines 81 to 88 in 47351aa

	if (DnxPlatformServices.Default?.LibraryManager != null)
	{
	services.TryAddTransient<IAssemblyProvider, DefaultAssemblyProvider>();
	}
	else
	{
	services.TryAddTransient<IAssemblyProvider, DependencyContextAssemblyProvider>();
	}

services.

[khellang]

To be clear, this pretty much means a single call to

services.Replace(ServiceDescriptor.Transient<IControllerActivator, ServiceBasedControllerActivator>());

Because the DefaultControllerTypeProvider already uses IAssemblyProvider to get to the assemblies, right?

[khellang]

Oh, and the controller type itself has to be registered in some way, DUH.

How do you get a registered IAssemblyProvider instance without building a service provider from the services?

Isn't this a bit of chicken and egg? You need to resolve from the container in order to add to it? 😄

[rynowak]

Isn't this a bit of chicken and egg? You need to resolve from the container in order to add to it?

Nah, we just assume the default type provider if you're using any of these methods. If you need to do something different these methods are only like 5 lines of code so write your own.

[khellang]

Nah, we just assume the default type provider if you're using any of these methods.

And what is the default going forward? DefaultAssemblyProvider or DependencyContextAssemblyProvider?

[rynowak]

I thought we were talking about the IControllerTypeProvider???

DependencyContextAssemblyProvider will be the default once we transition to .net cli

[khellang]

Basically, you want to ask the IAssemblyProvider for assemblies and pass those to the AddControllersAsServices(IEnumerable<Assembly>) overload, which internally uses DefaultControllerTypeProvider 😄

[danroth27]

Should this behavior actually be the default?

[davidfowl]

That came up but it's actually really hard to remove it if you don't want that behavior by default. You basically have to reverse engineer the controller type provider and remove services

[rynowak]

Iterating on design in this area - #4089