Move IRazorViewEngineFileProviderAccessor and ExpressionRewriter to the public namespace

[DavidEmanuelsen]

An application we're building has ended up needing to implement a modified version of DefaultRoslynCompilationService to avoid caching of the list of compilation references. In the modified version we still depend (as far as I can see) on IRazorViewEngineFileProviderAccessor and ExpressionRewriter which are both in the .Internal-namespace.

Is there any chance this can be moved to the public namespace to minimize risks of breaking changes in the future?

See #4497 for history

[Eilon]

@NTaylorMullen @pranavkm @rynowak thoughts on this? Would it make sense to move these types to a public namespace?

[davidfowl]

No, if you ended up rewriting the default service then we have a gap somewhere in our extensibility.

[rynowak]

@davidfowl - we did identify a gap here... remember when we designed compilation factory and reference manager?

We should make an abstraction for https://github.com/aspnet/Mvc/blob/dev/src/Microsoft.AspNetCore.Mvc.Razor/Internal/RazorReferenceManager.cs and make it public, that's the part you're asking for right @DavidEmanuelsen ?

[Eilon]

@rynowak I'm parking this on your plate. If you think we can get this in, let's do it, but if not, I think we should close it.

[rynowak]

c3f7613