Html.AntiForgeryToken helper throws exception on Mono #847

Praburaj · 2014-07-23T19:43:55Z

https://github.com/aspnet/Mvc/blob/dev/src/Microsoft.AspNet.Mvc.Core/AntiForgery/BinaryBlob.cs#L96

private static byte[] GenerateNewToken(int bitLength)
        {
            var data = new byte[bitLength / 8];
            CryptRand.FillBuffer(new ArraySegment<byte>(data));
            return data;
        }

System.DllNotFoundException: bcrypt.dll
  at (wrapper managed-to-native) Microsoft.AspNet.Security.DataProtection.UnsafeNativeMethods:BCryptGenRandom (intptr,byte*,uint,Microsoft.AspNet.Security.DataProtection.BCryptGenRandomFlags)
  at Microsoft.AspNet.Security.DataProtection.BCryptUtil.GenRandom (System.Byte* buffer, Int32 bufferBytes) [0x00000] in <filename unknown>:0 
  at Microsoft.AspNet.Security.DataProtection.CryptRand.FillBuffer (ArraySegment`1 buffer) [0x00000] in <filename unknown>:0 
  at Microsoft.AspNet.Mvc.BinaryBlob.GenerateNewToken (Int32 bitLength) [0x00000] in <filename unknown>:0 
  at Microsoft.AspNet.Mvc.BinaryBlob..ctor (Int32 bitLength) [0x00000] in <filename unknown>:0 
  at Microsoft.AspNet.Mvc.AntiForgeryToken.get_SecurityToken () [0x00000] in <filename unknown>:0 
  at Microsoft.AspNet.Mvc.TokenProvider.GenerateFormToken (Microsoft.AspNet.Http.HttpContext httpContext, System.Security.Claims.ClaimsIdentity identity, Microsoft.AspNet.Mvc.AntiForgeryToken cookieToken) [0x00000] in <filename unknown>:0 
  at Microsoft.AspNet.Mvc.AntiForgeryWorker.GetTokens (Microsoft.AspNet.Http.HttpContext httpContext, Microsoft.AspNet.Mvc.AntiForgeryToken oldCookieToken) [0x00000] in <filename unknown>:0 
  at Microsoft.AspNet.Mvc.AntiForgeryWorker.GetFormInputElement (Microsoft.AspNet.Http.HttpContext httpContext) [0x00000] in <filename unknown>:0 
  at Microsoft.AspNet.Mvc.AntiForgery.GetHtml (Microsoft.AspNet.Http.HttpContext context) [0x00000] in <filename unknown>:0 
  at Microsoft.AspNet.Mvc.Rendering.HtmlHelper.AntiForgeryToken () [0x00000] in <filename unknown>:0 
  at ASP.Views_StoreManager_Edit_cshtml+<ExecuteAsync>d__1.MoveNext () [0x00000] in <filename unknown>:0 
--- End of stack trace from previous location where exception was thrown ---
  at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x00000] in <filename unknown>:0 
  at System.Runtime.CompilerServices.TaskAwaiter.GetResult () [0x00000] in <filename unknown>:0 
  at Microsoft.AspNet.Mvc.Razor.RazorView+<RenderPageCoreAsync>d__1.MoveNext () [0x00000] in <filename unknown>:0 
--- End of stack trace from previous location where exception was thrown ---
  at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x00000] in <filename unknown>:0 
  at System.Runtime.CompilerServices.TaskAwaiter.GetResult () [0x00000] in <filename unknown>:0 
  at Microsoft.AspNet.Mvc.Razor.RazorView+<RenderPageAsync>d__1.MoveNext () [0x00000] in <filename unknown>:0 
--- End of stack trace from previous location where exception was thrown ---
  at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x00000] in <filename unknown>:0 
  at System.Runtime.CompilerServices.TaskAwaiter`1[TResult].GetResult () [0x00000] in <filename unknown>:0 
  at Microsoft.AspNet.Mvc.Razor.RazorView+<RenderAsync>d__1.MoveNext () [0x00000] in <filename unknown>:0 
--- End of stack trace from previous location where exception was thrown ---
  at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x00000] in <filename unknown>:0 
  at System.Runtime.CompilerServices.TaskAwaiter.GetResult () [0x00000] in <filename unknown>:0 
  at Microsoft.AspNet.Mvc.ViewResult+<ExecuteResultAsync>d__1.MoveNext () [0x00000] in <filename unknown>:0 
--- End of stack trace from previous location where exception was thrown ---
  at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x00000] in <filename unknown>:0 
  at System.Runtime.CompilerServices.TaskAwaiter.GetResult () [0x00000] in <filename unknown>:0 
  at Microsoft.AspNet.Mvc.ReflectedActionInvoker+<InvokeActionResult>d__1.MoveNext () [0x00000] in <filename unknown>:0 
--- End of stack trace from previous location where exception was thrown ---
  at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x00000] in <filename unknown>:0 
  at System.Runtime.CompilerServices.TaskAwaiter.GetResult () [0x00000] in <filename unknown>:0 
  at Microsoft.AspNet.Mvc.ReflectedActionInvoker+<InvokeActionResultFilter>d__1.MoveNext () [0x00000] in <filename unknown>:0 
--- End of stack trace from previous location where exception was thrown ---
  at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x00000] in <filename unknown>:0 
  at Microsoft.AspNet.Mvc.ReflectedActionInvoker+<InvokeActionResultWithFilters>d__1.MoveNext () [0x00000] in <filename unknown>:0 
--- End of stack trace from previous location where exception was thrown ---
  at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x00000] in <filename unknown>:0 
  at System.Runtime.CompilerServices.TaskAwaiter.GetResult () [0x00000] in <filename unknown>:0 
  at Microsoft.AspNet.Mvc.ReflectedActionInvoker+<InvokeActionAsync>d__1.MoveNext () [0x00000] in <filename unknown>:0 
--- End of stack trace from previous location where exception was thrown ---
  at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x00000] in <filename unknown>:0 
  at System.Runtime.CompilerServices.TaskAwaiter.GetResult () [0x00000] in <filename unknown>:0 
  at Microsoft.AspNet.Mvc.MvcRouteHandler+<RouteAsync>d__1.MoveNext () [0x00000] in <filename unknown>:0 
--- End of stack trace from previous location where exception was thrown ---
  at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x00000] in <filename unknown>:0 
  at System.Runtime.CompilerServices.TaskAwaiter.GetResult () [0x00000] in <filename unknown>:0 
  at Microsoft.AspNet.Routing.Template.TemplateRoute+<RouteAsync>d__1.MoveNext () [0x00000] in <filename unknown>:0 
--- End of stack trace from previous location where exception was thrown ---
  at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x00000] in <filename unknown>:0 
  at System.Runtime.CompilerServices.TaskAwaiter.GetResult () [0x00000] in <filename unknown>:0 
  at Microsoft.AspNet.Routing.RouteCollection+<RouteAsync>d__1.MoveNext () [0x00000] in <filename unknown>:0 
--- End of stack trace from previous location where exception was thrown ---
  at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x00000] in <filename unknown>:0 
  at System.Runtime.CompilerServices.TaskAwaiter.GetResult () [0x00000] in <filename unknown>:0 
  at Microsoft.AspNet.Builder.RouterMiddleware+<Invoke>d__1.MoveNext () [0x00000] in <filename unknown>:0 
--- End of stack trace from previous location where exception was thrown ---
  at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x00000] in <filename unknown>:0 
  at System.Runtime.CompilerServices.TaskAwaiter.GetResult () [0x00000] in <filename unknown>:0 
  at MusicStore.Startup+<<Configure>b__6>d__0.MoveNext () [0x00000] in <filename unknown>:0

Recommendation from Levi:
MVC should instead be using the RandomNumberGenerator class. CryptRand was just a temporary workaround because the CLR team didn’t have the crypto libraries ported over.

The text was updated successfully, but these errors were encountered:

Praburaj · 2014-07-23T19:45:00Z

@harshgMSFT

yishaigalatzer · 2014-07-23T20:47:33Z

@harshgMSFT please go ahead and make the change (preferably this week)

harshgMSFT · 2014-07-28T23:42:05Z

Prabu can you please verify and close?

Praburaj · 2014-07-28T23:44:16Z

This can be closed. If this is the same as the private that I tested, I can confirm this worked.

…)` return `string` - fixes #566 and part of #847 - allows compositions such as `@Html.Label("property", Html.Id("property"))` and `@Html.Raw(Html.DisplayText("property"))` (this one is not recommended) - adjust XML comments to match - add missing XML comments to `HtmlHelperValueExtensions` - nit: `TInnerModel` -> `TModelItem` - increase XML comment consistency for changed methods - generally make wording more consistent e.g. how we use words such as "returns" - use `<see langref="string|true|false|null"/>` more

- don't call other extension methods - #847 line 7 - remove extension methods that do nothing but pass through to the interface method - weren't exactly ambiguous (interface method wins) but were useless

- #847 line 7 sub-bullets - don't call extension methods from our templates - partially addressed in PR #934 (for methods changed there) - don't reference extension methods from XML comments

- don't call other extension methods - #847 line 7 - remove extension methods that do nothing but pass through to the interface method - weren't exactly ambiguous (interface method wins) but were useless

- #847 line 7 sub-bullets - don't call extension methods from our templates - partially addressed in PR #934 (for methods changed there) - don't reference extension methods from XML comments

@rynowak

- #847 line 1: copy XML comments from interfaces to extension methods - lots of wording changes to be more consistent - core text split from PR #866, where @rynowak and I hashed out the words - to extent possible, reuse words between method descriptions - add `<remarks>` describing behaviour of input helpers e.g. `CheckBox()` - add a few missing `<param/>` and `<typeparam/>` elements and fill in empty ones - display more HTML elements as tags - use `<c>true|false|null</c>` more often nits: - "The expression" -> "An expression" - make examples for `ObjectToDictionary()` and `AnonymousObjectToHtmlAttributes()` more consistent - move `<typeparam/>` elements (that existed) after all `<param/>` elements

@rynowak

- #847 line 1: copy XML comments from interfaces to extension methods - lots of wording changes to be more consistent - core text split from PR #866, where @rynowak and I hashed out the words - to extent possible, reuse words between method descriptions - add `<remarks>` describing behaviour of input helpers e.g. `CheckBox()` - add a few missing `<param/>` and `<typeparam/>` elements and fill in empty ones - display more HTML elements as tags - use `<c>true|false|null</c>` more often nits: - "The expression" -> "An expression" - make examples for `ObjectToDictionary()` and `AnonymousObjectToHtmlAttributes()` more consistent - move `<typeparam/>` elements (that existed) after all `<param/>` elements

@rynowak

- #847 line 1: copy XML comments from interfaces to extension methods - lots of wording changes to be more consistent - core text split from PR #866, where @rynowak and I hashed out the words - to extent possible, reuse words between method descriptions - add `<remarks>` describing behaviour of input helpers e.g. `CheckBox()` - add a few missing `<param/>` and `<typeparam/>` elements and fill in empty ones - display more HTML elements as tags - use `<c>true|false|null</c>` more often nits: - "The expression" -> "An expression" - make examples for `ObjectToDictionary()` and `AnonymousObjectToHtmlAttributes()` more consistent - move `<typeparam/>` elements (that existed) after all `<param/>` elements

@rynowak

- #847 line 1: copy XML comments from interfaces to extension methods - lots of wording changes to be more consistent - core text split from PR #866, where @rynowak and I hashed out the words - to extent possible, reuse words between method descriptions - add a few missing `<param/>` and `<typeparam/>` elements and fill in empty ones - display more HTML elements as tags - use `<c>true|false|null</c>` more often - add `<remarks/>` describing behaviour of input helpers e.g. `CheckBox()` - add `<remarks/>` explaining "renders" - add `<remarks/>` containing example expression names nits: - "The expression" -> "An expression" - make examples for `ObjectToDictionary()` and `AnonymousObjectToHtmlAttributes()` more consistent - move `<typeparam/>` elements (that existed) after all `<param/>` elements - explain "checked" attributes better, removing some duplicated words from the `RadioButton[For]()` descriptions - correct `routeValues` description in `GenerateForm()` comments

Praburaj added the bug label Jul 23, 2014

yishaigalatzer added this to the 6.0.0-alpha3 milestone Jul 23, 2014

yishaigalatzer assigned harshgMSFT Jul 23, 2014

harshgMSFT mentioned this issue Jul 24, 2014

Moving to RandomNumberGenerator as CryptRandom is not supported in Mono #857

Closed

harshgMSFT assigned Praburaj and unassigned harshgMSFT Jul 28, 2014

Praburaj closed this as completed Jul 28, 2014

dougbu mentioned this issue Aug 9, 2014

Improve XML comments in HtmlHelper and related classes and interfaces #961

Merged

dougbu mentioned this issue Aug 14, 2014

Improve IHtmlHelper, HtmlHelper, et cetera public API; correct inconsistencies #874

Closed

danroth27 changed the title ~~Html.AntiForgeryToken helper throws exception on mono~~ Html.AntiForgeryToken helper throws exception on Mono Aug 17, 2014

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Html.AntiForgeryToken helper throws exception on Mono #847

Html.AntiForgeryToken helper throws exception on Mono #847

Praburaj commented Jul 23, 2014

Praburaj commented Jul 23, 2014

yishaigalatzer commented Jul 23, 2014

harshgMSFT commented Jul 28, 2014

Praburaj commented Jul 28, 2014

Html.AntiForgeryToken helper throws exception on Mono #847

Html.AntiForgeryToken helper throws exception on Mono #847

Comments

Praburaj commented Jul 23, 2014

Praburaj commented Jul 23, 2014

yishaigalatzer commented Jul 23, 2014

harshgMSFT commented Jul 28, 2014

Praburaj commented Jul 28, 2014