This repository has been archived by the owner on Dec 14, 2018. It is now read-only.
Make HTML helper null handling consistent
#934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebased and made a small addition to the commit description. Otherwise unchanged. |
|
|
| @@ -231,7 +231,7 @@ public interface IHtmlHelper | |||
| /// </summary> | |||
| /// <param name="name">The name of the HTML element.</param> | |||
| /// <returns>The ID of the HTML element.</returns> | |||
| string GenerateIdFromName(string name); | |||
| string GenerateIdFromName([NotNull] string name); | |||
There was a problem hiding this comment.
Going back to #765, this might not make sense. The presence of [NotNull] on an interface doesn't guarantee the implementation would have a NotNull.
There was a problem hiding this comment.
👎 We're not fixing #765 right now and the rest of this interface uses [NotNull]. We should be consistent.
In any case those uses aren't really about guaranteeing an implementation has the same attribute (though a compiler extension or analysis tool that did that would be nice as well). More about complaints an analysis tool might make if it notices a potentially-null string passed to this method.
|
|
- #874 lines 3, 4, and 6 - correct `Value()` to treat a `null` expression name the same as `string.Empty` - add missing `[NotNull]` attributes in `EditorExtensions` and for `GenerateIdFromName()` - consistently pass `null` for default expression names to the helpers - for example, from extension methods - add test cases using `null` for expression name nits: - correct summary XML comment for `HtmlHelper` class - use named parameters and prefer interface (not extension) methods in changed calls - use `string.Empty` instead of `""` in a few tests
dougbu
added a commit
that referenced
this pull request
Aug 7, 2014
- correct XML comment typo introduced in `HtmlHelper` in 56d66c0 (bad merge) - fix missed `null` requirement for `@Html.RadioButtonFor()` and remove buried `null` check - add back `Environment.Newline` to `@Html.TextArea()` (was dropped though comment wasn't)
dougbu
added a commit
that referenced
this pull request
Aug 7, 2014
- correct XML comment typo introduced in `HtmlHelper` in 56d66c0 (bad merge) - fix missed `null` requirement for `@Html.RadioButtonFor()` and remove buried `null` check - add back `Environment.Newline` to `@Html.TextArea()` (was dropped though comment wasn't)
dougbu
added a commit
that referenced
this pull request
Aug 8, 2014
- correct XML comment typo introduced in `HtmlHelper` in 56d66c0 (bad merge) - fix missed `null` requirement for `@Html.RadioButtonFor()` and remove buried `null` check - add back `Environment.Newline` to `@Html.TextArea()` (was dropped though comment wasn't)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IHtmlHelper,HtmlHelper, et cetera public API; correct inconsistencies #874 lines 3, 4, and 6Value()to treat anullexpression name the same asstring.Empty[NotNull]attributes inEditorExtensionsand forGenerateIdFromName()nullfor default expression names to the helpersnullfor expression namenits:
HtmlHelperclass