Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

Consider redesigning CompilationResult so it does not throw when CompiledType is accessed #955

Closed
pranavkm opened this issue Aug 8, 2014 · 3 comments
Closed

Consider redesigning CompilationResult so it does not throw when CompiledType is accessed #955

pranavkm opened this issue Aug 8, 2014 · 3 comments
Assignees
@pranavkm
Labels
3 - Done API review enhancement
Milestone
1.0.0-beta4

Comments

@pranavkm
Copy link
Contributor

pranavkm commented Aug 8, 2014

#873 (comment)
@pranavkm pranavkm mentioned this issue Aug 8, 2014
Closed
@danroth27 danroth27 modified the milestones: 6.0.0-beta1, 6.0.0-rc1 Sep 24, 2014
@yishaigalatzer yishaigalatzer modified the milestones: 6.0.0-rc1, 6.0.0-beta3 Jan 14, 2015
@yishaigalatzer
Copy link
Contributor

There are a few other design issues:

  1. The CreateCompilationException can fail if the file cannot be read (e.g. locked or removed), we should be more protected there.
    https://github.com/aspnet/Mvc/blob/dev/src/Microsoft.AspNet.Mvc.Razor/Compilation/CompilationResult.cs#L107
  2. The class exposes a FilePath that relies on the file.PhysicalPath that doesn't necessarily exist. It should perhaps take the RazorFileInfo instead as input (or both) and provide a virtual path if the path is not available.

@yishaigalatzer
Copy link
Contributor

Please come up with a skeleton design and reassign

@pranavkm pranavkm assigned pranavkm and unassigned pranavkm Feb 13, 2015
pranavkm added a commit that referenced this issue Feb 20, 2015
@pranavkm
* Redesign CompilationResult so that it does not throw when CompiledT…
d6e47d4 
…ype is

accessed.
* Update to use ICompilationException interface from
  Microsoft.Framework.Runtime
* Update to use RoslynCompilationException

Fixes #955
@pranavkm pranavkm mentioned this issue Feb 20, 2015
Closed
pranavkm added a commit that referenced this issue Feb 23, 2015
@pranavkm
* Redesign CompilationResult so that it does not throw when CompiledT…
fc38efe 
…ype is

accessed.
* Update to use ICompilationException interface from
  Microsoft.Framework.Runtime
* Update to use RoslynCompilationException

Fixes #955
pranavkm added a commit that referenced this issue Feb 26, 2015
@pranavkm
* Redesign CompilationResult so that it does not throw when CompiledT…
dd70773 
…ype is

accessed.
* Update to use ICompilationException interface from
  Microsoft.Framework.Runtime
* Update to use RoslynCompilationException

Fixes #955
@dougbu
Copy link
Member

dougbu commented Mar 10, 2015

fix in commits 717c2bf and a4e01bf

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pranavkm pranavkm

Labels
3 - Done API review enhancement
Projects
None yet
Milestone
1.0.0-beta4
Development

No branches or pull requests
4 participants
@pranavkm @yishaigalatzer @danroth27 @dougbu