This repository has been archived by the owner on Dec 14, 2018. It is now read-only.
* Redesign CompilationResult so that it does not throw when CompiledType is accessed #2045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
| { | ||
| CompilationFailures = new[] { compilationFailure }; | ||
| } | ||
|
|
||
| /// <inheritdoc /> | ||
| public IEnumerable<ICompilationFailure> CompilationFailures { get; } | ||
|
|
||
| private static string FormatMessage(ICompilationFailure compilationFailure) |
There was a problem hiding this comment.
We changed Diagnostics \ Helios to not print compilation messages. So we can do better with showing exception messages in the debugger now.
|
cc @dougbu |
| /// <summary> | ||
| /// Creates a new instance of <see cref="CompilationResult"/>. | ||
| /// Creates a new instance of <see cref="CompilationResult"/> that represents a success in compilation. |
There was a problem hiding this comment.
"that represents" (contains exactly two noise words) -> "for"
There was a problem hiding this comment.
- and end with "a successful compilation"
- similarly, "for a failed compilation" below
|
⌚ |
|
Updated. I'll change the file names for |
| private Type _type; | ||
|
|
||
| /// <summary> | ||
| // <summary> |
|
|
with a couple of typos and nits fixed
| /// </summary> | ||
| public class CompilationFailure : ICompilationFailure | ||
| public class RazorCompilationFailure : ICompilationFailure |
There was a problem hiding this comment.
I could go either way on this naming. There isn't really any functionality in this class that makes this "razor" specific.
|
⌚ |
…ype is accessed. * Update to use ICompilationException interface from Microsoft.Framework.Runtime * Update to use RoslynCompilationException Fixes #955
|
Updated. |
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #955