Skip to content
This repository has been archived by the owner on Dec 19, 2018. It is now read-only.

Port C# codegen from CSharpRendering to new BasicWriter/TagHelperWriter #1051

Closed
rynowak opened this issue Mar 7, 2017 · 3 comments
Closed

Port C# codegen from CSharpRendering to new BasicWriter/TagHelperWriter #1051

rynowak opened this issue Mar 7, 2017 · 3 comments
Assignees
@ajaybhargavb
Labels
3 - Done task
Projects
2.0.0 Preview 1
Milestone
2.0.0-preview1

Comments

@rynowak
Copy link
Member

rynowak commented Mar 7, 2017

See #1050

Break this up into chunks and start porting code + adding unit tests in as small of bites as possible.
@rynowak rynowak added this to the 2.0.0-preview1 milestone Mar 7, 2017
@rynowak
Copy link
Member Author

rynowak commented Mar 7, 2017

This is one of the Razor big rocks remaining

@ajaybhargavb ajaybhargavb mentioned this issue Mar 30, 2017
Merged
@ajaybhargavb
Copy link
Contributor

ajaybhargavb commented Mar 31, 2017 •
edited
Loading

Checklist:

  • Using/Checksum
  • CSharpExpressionIRNode
  • CSharpStatementIRNode
  • HtmlAttributeIRNode (HtmlAttributeValueIRNode / CSharpAttributeValueIRNode)
  • HtmlContentIRNode
  • DeclareTagHelperFieldsIRNode
  • InitializeTagHelperStructureIRNode
  • SetTagHelperPropertyIRNode
  • AddTagHelperHtmlAttributeIRNode
  • CreateTagHelperIRNode
  • ExecuteTagHelpersIRNode
  • Preallocated IR Nodes
  • DirectiveTokenIRNode

This was referenced Apr 3, 2017
Merged
Merged
Merged
Merged
Merged
@rynowak rynowak added this to Working in 2.0.0 Preview 1 Apr 10, 2017
@ajaybhargavb ajaybhargavb mentioned this issue Apr 14, 2017
Merged
@rynowak rynowak removed the Evolution label Apr 14, 2017
This was referenced Apr 15, 2017
Merged
Merged
Merged
Merged
ajaybhargavb added a commit that referenced this issue Apr 21, 2017
@ajaybhargavb
Finish writer implementation of the remaining IR nodes and added tests
41ea2f7 
- SetTagHelperPropertyIRNode
- ChecksumIRNode
- UsingStatementIRNode
- Preallocated attributes target extension
- HtmlAttributeIRNode and friends
- Design time directive helper target extension
- Removed renderers and rendering conventions
- Regenerated IR baselines
Issue - #846 and #1051
ajaybhargavb added a commit that referenced this issue Apr 21, 2017
@ajaybhargavb
Finish writer implementation of the remaining IR nodes and added tests
e1ad454 
- SetTagHelperPropertyIRNode
- ChecksumIRNode
- UsingStatementIRNode
- Preallocated attributes target extension
- HtmlAttributeIRNode and friends
- Design time directive helper target extension
- Removed renderers and rendering conventions
- Regenerated IR baselines
Issue - #846 and #1051
ajaybhargavb added a commit that referenced this issue Apr 21, 2017
@ajaybhargavb
Finish writer implementation of the remaining IR nodes and added tests
4e2cd0c 
- SetTagHelperPropertyIRNode
- ChecksumIRNode
- UsingStatementIRNode
- Preallocated attributes target extension
- HtmlAttributeIRNode and friends
- Design time directive helper target extension
- Removed renderers and rendering conventions
- Regenerated IR baselines
Issue - #846 and #1051
@ajaybhargavb
Copy link
Contributor

Dup of #846

@rynowak rynowak moved this from Working to Done in 2.0.0 Preview 1 Apr 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ajaybhargavb ajaybhargavb

Labels
3 - Done task
Projects
No open projects
2.0.0 Preview 1
Done
Milestone
2.0.0-preview1
Development

No branches or pull requests
2 participants
@rynowak @ajaybhargavb