Skip to content
This repository has been archived by the owner on Dec 19, 2018. It is now read-only.

Core: Implement API sets multitargeting for CSharp #846

Closed
NTaylorMullen opened this issue Nov 2, 2016 · 2 comments
Closed

Core: Implement API sets multitargeting for CSharp #846

NTaylorMullen opened this issue Nov 2, 2016 · 2 comments
Assignees
@ajaybhargavb
Labels
3 - Done feature
Milestone
2.0.0-preview1

Comments

@NTaylorMullen
Copy link
Member

Today we rely on a massive contextual object that contains strings used at code generation time. This has been a very painful way to enable code generation extensibility in Razor; should improve on it. 💪
@NTaylorMullen NTaylorMullen changed the title Implement API sets multitargeting for CSharp Core: Implement API sets multitargeting for CSharp Nov 2, 2016
@NTaylorMullen NTaylorMullen added this to the 1.2.0 milestone Nov 2, 2016
@rynowak rynowak modified the milestone: 1.2.0 Nov 2, 2016
@NTaylorMullen NTaylorMullen added this to the 1.2.0 milestone Nov 2, 2016
@NTaylorMullen
Copy link
Member Author

NTaylorMullen commented Dec 15, 2016 •
edited
Loading

When we tackle this feature we should also take a look at DefineSection since it'd be nice to have its signature be string, Action; instead string, Action<T> (needed for back compat). This is all to enable us to not bring forward WriteTo, WriteLiteralTo etc.

@rynowak rynowak assigned ajaybhargavb and unassigned rynowak Mar 9, 2017
@rynowak rynowak removed the Evolution label Apr 14, 2017
ajaybhargavb added a commit that referenced this issue Apr 21, 2017
@ajaybhargavb
Finish writer implementation of the remaining IR nodes and added tests
41ea2f7 
- SetTagHelperPropertyIRNode
- ChecksumIRNode
- UsingStatementIRNode
- Preallocated attributes target extension
- HtmlAttributeIRNode and friends
- Design time directive helper target extension
- Removed renderers and rendering conventions
- Regenerated IR baselines
Issue - #846 and #1051
ajaybhargavb added a commit that referenced this issue Apr 21, 2017
@ajaybhargavb
Finish writer implementation of the remaining IR nodes and added tests
e1ad454 
- SetTagHelperPropertyIRNode
- ChecksumIRNode
- UsingStatementIRNode
- Preallocated attributes target extension
- HtmlAttributeIRNode and friends
- Design time directive helper target extension
- Removed renderers and rendering conventions
- Regenerated IR baselines
Issue - #846 and #1051
ajaybhargavb added a commit that referenced this issue Apr 21, 2017
@ajaybhargavb
Finish writer implementation of the remaining IR nodes and added tests
4e2cd0c 
- SetTagHelperPropertyIRNode
- ChecksumIRNode
- UsingStatementIRNode
- Preallocated attributes target extension
- HtmlAttributeIRNode and friends
- Design time directive helper target extension
- Removed renderers and rendering conventions
- Regenerated IR baselines
Issue - #846 and #1051
@ajaybhargavb ajaybhargavb mentioned this issue Apr 21, 2017
Closed
@ajaybhargavb
Copy link
Contributor

da1e413
7d8bd29
4dbf6f2
6fea645
0228fd2
fe60c24
0b17f14
4e2cd0c

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ajaybhargavb ajaybhargavb

Labels
3 - Done feature
Projects
None yet
Milestone
2.0.0-preview1
Development

No branches or pull requests
3 participants
@rynowak @ajaybhargavb @NTaylorMullen