Skip to content
This repository has been archived by the owner on Dec 19, 2018. It is now read-only.

CodeGeneration should not generate line pragmas from unknown file paths #1110

Closed
NTaylorMullen opened this issue Mar 22, 2017 · 1 comment
Closed

Comments

@NTaylorMullen
Copy link
Member

In the case of MVC extensions we generate dynamic _ViewImports.cshtml file equivalents that don't end up having any actual existence on disk. When one of those files has an @using Foo we codegen a line pragma for Foo that does not have a filename. We don't want innaccurate line pragma errors due to lack of file name so we shouldn't render a pragma if a filename is not set on a source location.

@NTaylorMullen NTaylorMullen self-assigned this Apr 4, 2017
@NTaylorMullen NTaylorMullen added this to the 2.0.0-preview1 milestone Apr 4, 2017
NTaylorMullen added a commit that referenced this issue Apr 4, 2017
- Prior to this change default imports would get line pragmas generated for them because thye'd have a source location but no file path (they were a dynamic document).
- Re-generated C# files to reflect new line pragma changes.

#1110
NTaylorMullen added a commit that referenced this issue Apr 4, 2017
- Prior to this change default imports would get line pragmas generated for them because thye'd have a source location but no file path (they were a dynamic document).
- Re-generated C# files to reflect new line pragma changes.

#1110
NTaylorMullen added a commit that referenced this issue Apr 4, 2017
- Prior to this change default imports would get line pragmas generated for them because thye'd have a source location but no file path (they were a dynamic document).
- Re-generated C# files to reflect new line pragma changes.

#1110
@NTaylorMullen
Copy link
Member Author

fdc8f79

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant