This repository has been archived by the owner on Dec 19, 2018. It is now read-only.
Do not generate C# line pragmas without a file path. #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajaybhargavb
approved these changes
Apr 4, 2017
| if (string.IsNullOrEmpty(documentLocation.FilePath)) | ||
| { | ||
| // Can't build a valid line pragma without a file path. | ||
| return new NoopDisposable(); |
There was a problem hiding this comment.
Return a static instance instead of newing it up everytime
| @@ -632,5 +638,12 @@ public void Dispose() | |||
| .SetIndent(_startIndent); | |||
| } | |||
| } | |||
|
|
|||
| private class NoopDisposable : IDisposable | |||
There was a problem hiding this comment.
Suggest NullDisposable or EmptyDisposable. Feel free to ignore this comment.
- Prior to this change default imports would get line pragmas generated for them because thye'd have a source location but no file path (they were a dynamic document). - Re-generated C# files to reflect new line pragma changes. #1110
NTaylorMullen
force-pushed
the
nimullen/nullfilepaths.1110
branch
from
92c7fc7
to
fdc8f79
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1110