Skip to content
This repository has been archived by the owner on Dec 19, 2018. It is now read-only.

TagHelperElementCompletionService does not apply CatchAlls to existing completions #1219

Closed
NTaylorMullen opened this issue Apr 13, 2017 · 1 comment
Assignees

Comments

@NTaylorMullen
Copy link
Member

If you have TagHelper that applies to every tag (*) old IntelliSense would apply that TagHelper to every tag in IntelliSense. This means when IntelliSense would pop-up for you all your completions would have a TagHelper icon and corresponding TagHelper listed next to them.

@NTaylorMullen NTaylorMullen added this to the 2.0.0-preview1 milestone Apr 13, 2017
@NTaylorMullen NTaylorMullen self-assigned this Apr 13, 2017
NTaylorMullen added a commit that referenced this issue Apr 13, 2017
- Prior to this catch-alls were explicitly ignored not to populate the IntelliSense with an excess amount of `TagHelper`s. To maintain backwards compatible expectations this commit reverts that expectation.
- Scoped an existing test to only test its primary scenario.
- Added a new test to verify that catch-alls accurately apply to all completions (including dynamically added ones).

#1219
NTaylorMullen added a commit that referenced this issue Apr 13, 2017
- Prior to this catch-alls were explicitly ignored not to populate the IntelliSense with an excess amount of `TagHelper`s. To maintain backwards compatible expectations this commit reverts that expectation.
- Scoped an existing test to only test its primary scenario.
- Added a new test to verify that catch-alls accurately apply to all completions (including dynamically added ones).

#1219
NTaylorMullen added a commit that referenced this issue Apr 14, 2017
- Prior to this catch-alls were explicitly ignored not to populate the IntelliSense with an excess amount of `TagHelper`s. To maintain backwards compatible expectations this commit reverts that expectation.
- Scoped an existing test to only test its primary scenario.
- Added a new test to verify that catch-alls accurately apply to all completions (including dynamically added ones).

#1219
@NTaylorMullen
Copy link
Member Author

46a5ca9

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant