Adding infrastructure to write node (a.k.a. unit) tests for ts client (…

…#129)

package.json

@@ -7,7 +7,9 @@
     "test": "test"
   },
   "scripts": {
-    "gulp": "gulp"
+    "gulp": "gulp",
+    "pretest": "tsc -p test/Microsoft.AspNetCore.Client.SignalR.TS.Tests",
+    "test": "jasmine JASMINE_CONFIG_PATH=test/Microsoft.AspNetCore.Client.SignalR.TS.Tests/jasmine.json"
   },
   "repository": {
     "type": "git",

src/Microsoft.AspNetCore.SignalR.Client.TS/Common.ts

@@ -1,3 +1,3 @@
-declare type DataReceived = (data: any) => void;
-declare type ErrorHandler = (e: any) => void;
-declare type ConnectionClosed = (e?: any) => void;
+export declare type DataReceived = (data: any) => void;
+export declare type ErrorHandler = (e: any) => void;
+export declare type ConnectionClosed = (e?: any) => void;

src/Microsoft.AspNetCore.SignalR.Client.TS/Connection.ts

@@ -1,3 +1,4 @@
+import { DataReceived, ConnectionClosed } from "./Common"
 import { ITransport, WebSocketTransport, ServerSentEventsTransport, LongPollingTransport } from "./Transports"
 import { IHttpClient, HttpClient } from "./HttpClient"
 import { ISignalROptions } from "./ISignalROptions"

src/Microsoft.AspNetCore.SignalR.Client.TS/HubConnection.ts

@@ -1,3 +1,4 @@
+import { ConnectionClosed } from "./Common"
 import { Connection } from "./Connection"
 
 interface InvocationDescriptor {
@@ -28,7 +29,7 @@ export class HubConnection {
             thisHubConnection.dataReceived(data);
         };
 
-        this.callbacks = new Map<string, (InvocationResultDescriptor) => void>();
+        this.callbacks = new Map<string, (invocationDescriptor: InvocationResultDescriptor) => void>();
         this.methods = new Map<string, (...args: any[]) => void>();
         this.id = 0;
     }

src/Microsoft.AspNetCore.SignalR.Client.TS/Transports.ts

@@ -1,3 +1,4 @@
+import { DataReceived, ErrorHandler } from "./Common"
 import { IHttpClient } from "./HttpClient"
 
 export interface ITransport {

src/Microsoft.AspNetCore.SignalR.Client.TS/tsconfig.json

@@ -3,7 +3,16 @@
     "compilerOptions": {
         "module": "umd",
         "target": "es6",
+        "sourceMap": true,
+        "emitDecoratorMetadata": true,
+        "experimentalDecorators": true,
+        "removeComments": false,
+        "noImplicitAny": true,
+        "suppressImplicitAnyIndexErrors": true,
         "outDir": "../../artifacts/lib/signalr-client-modules"
     },
-    "include": [ "*.ts" ]
+    "include": [
+        "./**/*",
+        "../../typings/*"
+    ]
 }

test/Microsoft.AspNetCore.Client.SignalR.TS.Tests/Connection.spec.ts

@@ -0,0 +1,30 @@
+import {IHttpClient} from "../../src/Microsoft.AspNetCore.SignalR.Client.TS/HttpClient"
+import { Connection } from "../../src/Microsoft.AspNetCore.SignalR.Client.TS/Connection"
+import { ISignalROptions } from "../../src/Microsoft.AspNetCore.SignalR.Client.TS/ISignalROptions"
+
+describe("Connection", () => {
+    it("starting connection fails if getting id fails", async (done) => {
+        let options: ISignalROptions = {
+            httpClient: <IHttpClient>{
+                get(url: string): Promise<string> {
+                    if (url.indexOf("/getid") >= 0) {
+                        return Promise.reject("error");
+                    }
+                    return Promise.resolve("");
+                }
+            }
+        } as ISignalROptions;
+
+        let connection = new Connection("http://tempuri.org", undefined, options);
+
+        try {
+            await connection.start();
+            fail();
+            done();
+        }
+        catch (e) {
+            expect(e).toBe("error");
+            done();
+        }
+    });
+});

test/Microsoft.AspNetCore.Client.SignalR.TS.Tests/jasmine.json

@@ -0,0 +1,6 @@
+{
+    "spec_dir": "artifacts/test/Microsoft.AspNetCore.Client.SignalR.TS.Tests",
+    "spec_files": [
+        "./**/*[sS]pec.js"
+    ]
+}

test/Microsoft.AspNetCore.Client.SignalR.TS.Tests/tsconfig.json

@@ -0,0 +1,18 @@
+{
+    "compileOnSave": true,
+    "compilerOptions": {
+        "module": "umd",
+        "target": "es6",
+        "sourceMap": true,
+        "emitDecoratorMetadata": true,
+        "experimentalDecorators": true,
+        "removeComments": false,
+        "noImplicitAny": true,
+        "suppressImplicitAnyIndexErrors": true,
+        "outDir": "../../artifacts/test/Microsoft.AspNetCore.Client.SignalR.TS.Tests/"
+    },
+    "include": [
+        "./**/*",
+        "../../typings/*"
+    ]
+}

test/Microsoft.AspNetCore.SignalR.Test.Server/wwwroot/js/common.js

@@ -4,7 +4,3 @@ function eachTransport(action) {
    let transportNames = ["webSockets", "serverSentEvents", "longPolling"];
    transportNames.forEach(t => action(t));
 }
-
-function fail() {
-    it.expect(true).toBe(false);
-}

src/Microsoft.AspNetCore.SignalR.Client.TS/EventSource.d.ts → typings/globals/EventSource/EventSource.d.ts

@@ -10,7 +10,7 @@ declare class EventSource extends EventTarget {
     readonly CONNECTING: number;
     readonly OPEN: number;
 
-    close();
+    close(): void;
 
     onerror: (this: this, ev: ErrorEvent) => any;
     onmessage: (this: this, ev: MessageEvent) => any;