Use ActivatorUtlities.CreateFactory instead of CreateInstance

[davidfowl]

• Turns out CreateFactory is much much faster
• Added a benchmark for hub activation

Before

 Method |     Mean |    Error |   StdDev |        Op/s |  Gen 0 | Allocated |
------- |---------:|---------:|---------:|------------:|-------:|----------:|
 Create | 710.7 ns | 14.40 ns | 39.89 ns | 1,406,988.1 | 0.0153 |     224 B |

After

  Method |     Mean |    Error |   StdDev |         Op/s |  Gen 0 | Allocated |
------- |---------:|---------:|---------:|-------------:|-------:|----------:|
 Create | 76.34 ns | 3.347 ns | 9.386 ns | 13,099,035.7 | 0.0037 |      48 B |

Lazy

 Method |     Mean |    Error |   StdDev |   Median |         Op/s |  Gen 0 | Allocated |
------- |---------:|---------:|---------:|---------:|-------------:|-------:|----------:|
 Create | 65.39 ns | 1.480 ns | 4.102 ns | 63.73 ns | 15,292,741.1 | 0.0037 |      48 B |

Fixes #1570

[JamesNK]

This is a pretty heavy operation to have in a static constructor. Also if the hub type is registered with the service provider then we'll never even use the factory. IMO create the factory when it is needed

[davidfowl]

I looked at that, I can make it lazy.

[davidfowl]

🆙 📅 . Seems like it got even faster after it was made lazy 😄

[JamesNK]

readonly

[pakrym]

Why did you need full on Lazy<T>? Null check would be just fine.

[davidfowl]

Why did you need full on Lazy? Null check would be just fine.

You're right. I guess worst case we would have compiled a few times. Meh.