This repository has been archived by the owner on Dec 18, 2018. It is now read-only.
Message pack protocol in TS client #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moozzyk
force-pushed
the
pawelka/msgpack-js
branch
from
bbe5f52
to
c2af960
Compare
moozzyk
force-pushed
the
pawelka/msgpack-js
branch
3 times, most recently
from
5dab8bd
to
e853651
Compare
|
🆙📅 - rebased on latest dev |
moozzyk
force-pushed
the
pawelka/msgpack-js
branch
from
e853651
to
a0fb5c1
Compare
moozzyk
commented
Aug 7, 2017
client-ts/package.json
Outdated
| "browserify": "^13.1.1", | ||
| "del": "^2.2.2", | ||
| "gulp": "^3.9.1", | ||
| "gulp-typescript": "^3.1.3", | ||
| "jasmine": "^2.5.2", | ||
| "msgpack-lite": "^0.1.26", |
There was a problem hiding this comment.
Actually looking if we can use https://github.com/mcollina/msgpack5 which is not 0.x
moozzyk
commented
Aug 7, 2017
| import { IHubProtocol, MessageType, HubMessage, InvocationMessage, ResultMessage, CompletionMessage } from "./IHubProtocol"; | ||
| import { BinaryMessageFormat } from "./Formatters" | ||
|
|
||
| var msgpack = require("msgpack-lite"); |
There was a problem hiding this comment.
They added typings a day after I wrote this code. Switching to typings will make this ugliness go away.
moozzyk
commented
Aug 7, 2017
| "browserify": "^13.1.1", | ||
| "del": "^2.2.2", | ||
| "gulp": "^3.9.1", | ||
| "gulp-typescript": "^3.1.3", | ||
| "jasmine": "^2.5.2", | ||
| "msgpack5": "^3.5.0", |
|
🆙📅 |
Eilon
approved these changes
Aug 7, 2017
| "browserify": "^13.1.1", | ||
| "del": "^2.2.2", | ||
| "gulp": "^3.9.1", | ||
| "gulp-typescript": "^3.1.3", | ||
| "jasmine": "^2.5.2", | ||
| "msgpack5": "^3.5.0", |
There was a problem hiding this comment.
This package is approved for use here. I logged #696 for adding the third party notices file.
Before we would rely on error being null to detect whether to read results and we had an additional 'hasResult' field. Now all this information is codified in a field.
Makes it much easier to parse in JavaScript (also is more MsgPacky)
moozzyk
force-pushed
the
pawelka/msgpack-js
branch
from
82eb84b
to
a3ab684
Compare
|
⌚ - still need a review. @Eilon approval is for usage of msgpack5 and not the PR in general. |
davidfowl
approved these changes
Aug 9, 2017
|
Yes, spec update is coming. |
moozzyk
commented
Aug 9, 2017
| @@ -137,32 +148,41 @@ private void WriteMessageCore(HubMessage message, Stream output) | |||
|
|
|||
| private static void WriteInvocationMessage(InvocationMessage invocationMessage, Packer packer, Stream output) | |||
| { | |||
| packer.PackArrayHeader(5); | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: it is not plugged in yet - #677 required to make it work end-to-end)