This repository has been archived by the owner on Nov 22, 2018. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When serving a static directory whose path string contains unicode codes , let's say
blog/categories/大道/index.html
blog/categories/大道/index.html
The
DefaultFileMiddlware
gets the directory byvar dirContents = _fileProvider.GetDirectoryContents(subpath.Value);
. And now when we check whether the path ofblog/categories/大道/
exists as below :StaticFiles/src/Microsoft.AspNetCore.StaticFiles/DefaultFilesMiddleware.cs
Line 69 in 4c8df8e
The result will be true .
However , when coming into the default
index.html
, theDefaultFileMiddlware
checks the file path by :Here the
subpath
is often urlencoded , so the file path will be something as below :As a result ,
file.Exists
will returnfalse
.