This repository has been archived by the owner on Dec 20, 2018. It is now read-only.
React to breaking changes in Microsoft.AspNetCore.App #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add packages references for EF Core, when necessary * Add packages references for SpaServices to Spa templates * Remove PackageReference to Microsoft.AspNetCore.App altogether
natemcmaster
commented
Nov 16, 2018
src/Microsoft.DotNet.Web.ProjectTemplates/RazorClassLibrary-CSharp.csproj.in
Show resolved
Hide resolved
dsplaisted
approved these changes
Nov 16, 2018
src/Microsoft.DotNet.Web.ProjectTemplates/RazorClassLibrary-CSharp.csproj.in
Show resolved
Hide resolved
|
cc @ajcvickers you may be interested too, since most of this was about adding PackageRefs for EFCore |
natemcmaster
changed the title
|
🆙 📅 tests are passing with the latest build of aspnetcore. |
ryanbrandenburg
approved these changes
Nov 16, 2018
| @@ -12,7 +12,7 @@ | |||
| </PropertyGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <PackageReference Include="Microsoft.AspNetCore.App" /> | |||
There was a problem hiding this comment.
I guess I'm confused about under what circumstances we need a FrameworkReference? Why do we need it in RazorClassLibrary but not here?
There was a problem hiding this comment.
The current plan of record is that Microsoft.NET.Sdk.Web implies a FrameworkReference to aspnetcore. RazorClassLibrary doesn't use the websdk, it uses Microsoft.NET.Sdk.Razor
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP until dotnet/aspnetcore#4004 merges and has a build available.Changes:
Resolves dotnet/aspnetcore#3612
cc @dsplaisted