This repository has been archived by the owner on Dec 18, 2017. It is now read-only.
Wei/dnu publish include symbols #2153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Looks great! Can you add a test?
ChengTian
force-pushed
the
wei/dnu-publish-include-symbols
branch
from
6037f0d
to
13a0f53
Compare
|
Added functional test. AppVeyor is slow so I verified it on Windows locally. |
| var exitCode = DnuTestUtils.ExecDnu( | ||
| runtimeHomeDir, | ||
| subcommand: "publish", | ||
| arguments: string.Format("--no-source --include-symbols --out {0}", publishOutputPath), |
ChengTian
force-pushed
the
wei/dnu-publish-include-symbols
branch
from
13a0f53
to
aad4a3c
Compare
ChengTian
force-pushed
the
wei/dnu-publish-include-symbols
branch
from
aad4a3c
to
6410c8d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parent #1647
@davidfowl