This repository has been archived by the owner on Dec 18, 2017. It is now read-only.
Update embedded RID definitions for Ubuntu and OS X #2780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
analogrelay
force-pushed
the
anurse/2594-rid-fallback
branch
from
ce17557
to
0ba0a91
Compare
| new RuntimeSpec("ubuntu-x64", "ubuntu", "linux-x64"), | ||
|
|
||
| new RuntimeSpec("ubuntu.14.04", "ubuntu"), | ||
| new RuntimeSpec("ubuntu.14.04-x64", "ubuntu.14.04", "ubuntu-x64")); |
There was a problem hiding this comment.
Where do we get this list from?
There was a problem hiding this comment.
Microsoft.NETCore.Platforms package
There was a problem hiding this comment.
Do we need to have a process or automation to keep these two in sync?
There was a problem hiding this comment.
I don't think so. It would take more effort than it's worth since we only need to modify this when DNX adds support for a new platform.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2594
/cc @davidfowl @BrennanConroy @ericstj