Skip to content
This repository has been archived by the owner on Dec 13, 2018. It is now read-only.

Replace any Task.Result calls with Task.GetAwaiter().GetResult() #59

Closed
Tratcher opened this issue Sep 9, 2014 · 0 comments
Closed
Assignees
Milestone

Comments

@Tratcher
Copy link
Member

Tratcher commented Sep 9, 2014

There are several places where the auth handler has a sync and an async code path, but the sync path must call the async path and block (Task.Wait/Result).

"One last remark: you should avoid using Task.Result and Task.Wait as much as possible as they always encapsulate the inner exception in an AggregateException and replace the message by a generic one (One or more errors occurred), which makes debugging harder. Even if the synchronous version shouldn't be used that often, you should strongly consider using Task.GetAwaiter().GetResult() instead." - Pinpoint

@Tratcher Tratcher self-assigned this Sep 15, 2014
@Tratcher Tratcher mentioned this issue Oct 10, 2014
@Tratcher Tratcher added this to the 1.0.0-beta1 milestone Oct 13, 2014
@Tratcher Tratcher removed the 3 - Done label Oct 20, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant