Refactor .Result to .GetAwaiter().GetResult() to preserve stacktrace #926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rational is explained at aspnet/Security#59. "One last remark: you should avoid using Task.Result and Task.Wait as much as possible as they always encapsulate the inner exception in an AggregateException and replace the message by a generic one (One or more errors occurred), which makes debugging harder. Even if the synchronous version shouldn't be used that often, you should strongly consider using Task.GetAwaiter().GetResult() instead." This leaves aside another possibility to refactor, namely that of making the interface method asynchronous.
sergeybykov
added a commit
that referenced
this pull request
Oct 20, 2015
Refactor .Result to .GetAwaiter().GetResult() to preserve stacktrace
|
Thank you, @veikkoeeva! This was an easy one. :-) |
|
@sergeybykov Yeah, and @dVakulen already rolled over that too. :) The #929 is a nice catch, I have even a faint memory of it being discussed in the beginning the era of Github. :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rational is explained at aspnet/Security#59.
"One last remark: you should avoid using Task.Result and Task.Wait as
much as possible as they always encapsulate the inner exception in an
AggregateException and replace the message by a generic one (One or
more errors occurred), which makes debugging harder. Even if the
synchronous version shouldn't be used that often, you should strongly
consider using Task.GetAwaiter().GetResult() instead."
This leaves aside another possibility to refactor, namely that of
making the interface method asynchronous.