Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed string.Format arguments number error #1407

Merged
merged 1 commit into from
Feb 8, 2016

Conversation

dVakulen
Copy link
Contributor

@dVakulen dVakulen commented Feb 6, 2016

#1395

The RETRIES parameter is no longer used:

devenv_2016-02-06_11-43-59

@@ -166,7 +166,7 @@ private static void UnregisterGrain(string[] args)

var directory = GrainClient.InternalGrainFactory.GetSystemTarget<IRemoteGrainDirectory>(Constants.DirectoryServiceId, silo);

WriteStatus(string.Format("**Calling DeleteGrain({0}, {1}, {2})", silo, grainId));
WriteStatus(string.Format("**Calling DeleteGrain({0}, {1})", silo, grainId));
directory.DeleteGrainAsync(grainId).Wait();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks OK, but I wonder if this method should be changed to an async one or GetAwaiter().GetResult() used instead, as has come up before.

@dVakulen knows this, but included to bring context for larger audience, more information here and here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change can be made in scope of the #1378.

@jthelin jthelin added the bug label Feb 8, 2016
jthelin added a commit that referenced this pull request Feb 8, 2016
Fixed string.Format arguments number error. 
Fixes #1395
@jthelin jthelin merged commit 421803a into dotnet:master Feb 8, 2016
@dVakulen dVakulen deleted the str-format--wrong-params-count branch February 8, 2016 08:44
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants