Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Await ToListAsync in GetAllSendAttemptsByWebhookEventIdAsync #5450

Merged
merged 3 commits into from
Mar 31, 2020
Merged

Await ToListAsync in GetAllSendAttemptsByWebhookEventIdAsync #5450

merged 3 commits into from
Mar 31, 2020

Conversation

acjh
Copy link
Contributor

@acjh acjh commented Mar 29, 2020

Follows #5211

Also implements FakeAsyncQueryableExecuter:

FakeAsyncQueryableExecuter awaits an asynchronous Task before executing an operation synchronously. This differs from NullAsyncQueryableExecuter a.k.a. SyncQueryableExecuter1, which actually only executes an operation synchronously. This can be used with tests to catch code that does not properly await a Task in a using block.

1 SyncQueryableExecuter was mentioned in #5356 (comment).

@acjh acjh added the bug label Mar 29, 2020
@acjh acjh requested a review from demirmusa March 29, 2020 11:18
@ismcagdas ismcagdas added this to the v5.5 milestone Mar 29, 2020
@ismcagdas ismcagdas merged commit 5dbdc8a into aspnetboilerplate:dev Mar 31, 2020
@acjh acjh mentioned this pull request May 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@demirmusa demirmusa demirmusa approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v5.5
Development

Successfully merging this pull request may close these issues.
3 participants
@acjh @demirmusa @ismcagdas