Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove simulate intro to align with good CLI practices #1427

Merged
merged 4 commits into from
May 17, 2023
Merged

Remove simulate intro to align with good CLI practices #1427

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ea9dd39
Remove simulate intro
J535D165 May 6, 2023
a80670f
Merge branch 'master' into remove-simulate-intro
J535D165 May 7, 2023
70b8c42
Merge branch 'master' into remove-simulate-intro
J535D165 May 8, 2023
074ab1b
Add accidently removed import
J535D165 May 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Empty file added .asreview
View file
Open in desktop
Empty file.
12 changes: 0 additions & 12 deletions asreview/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,6 @@
# See the License for the specific language governing permissions and
# limitations under the License.

ASCII_LOGO = """
_____ _____ _
/\ / ____| __ \ (_)
/ \ | (___ | |__) |_____ ___ _____ __
/ /\ \ \___ \| _ // _ \ \ / / |/ _ \ \ /\ / /
/ ____ \ ____) | | \ \ __/\ V /| | __/\ V V /
/_/ \_\_____/|_| \_\___| \_/ |_|\___| \_/\_/
""" # noqa

LABEL_NA = -1

KERAS_MODELS = ["lstm_base", "lstm_pool"]
Expand All @@ -40,9 +31,6 @@
DEFAULT_N_PRIOR_INCLUDED = 1
DEFAULT_N_PRIOR_EXCLUDED = 1

GITHUB_PAGE = "https://github.com/asreview/asreview"
EMAIL_ADDRESS = "asreview@uu.nl"

LEGACY_STATE_EXTENSIONS = [".h5", ".hdf5", ".he5", ".json"]

COLUMN_DEFINITIONS = {
Expand Down
23 changes: 0 additions & 23 deletions asreview/entry_points/simulate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,17 +18,13 @@
from pathlib import Path

from asreview.compat import convert_id_to_idx
from asreview.config import ASCII_LOGO
from asreview.config import DEFAULT_BALANCE_STRATEGY
from asreview.config import DEFAULT_FEATURE_EXTRACTION
from asreview.config import DEFAULT_MODEL
from asreview.config import DEFAULT_N_INSTANCES
from asreview.config import DEFAULT_N_PRIOR_EXCLUDED
from asreview.config import DEFAULT_N_PRIOR_INCLUDED
from asreview.config import DEFAULT_QUERY_STRATEGY
from asreview.config import EMAIL_ADDRESS
from asreview.config import GITHUB_PAGE
from asreview.data import ASReviewData
from asreview.data import load_data
from asreview.entry_points.base import BaseEntryPoint
from asreview.entry_points.base import _base_parser
Expand All @@ -44,22 +40,6 @@
from asreview.types import type_n_queries
from asreview.utils import get_random_state

ASCII_MSG_SIMULATE = """
---------------------------------------------------------------------------------
| |
| Welcome to ASReview LAB - AI-assisted systematic reviews software. |
| In simulation mode the computer will simulate how well ASReview LAB |
| could have accelerate the systematic review of your dataset. |
| You can sit back and relax while the computer runs this simulation. |
| |
| GitHub page: {0: <58}|
| Questions/remarks: {1: <58}|
| |
---------------------------------------------------------------------------------
""".format(
GITHUB_PAGE, EMAIL_ADDRESS
) # noqa


def _get_dataset_path_from_args(args_dataset):
"""Remove 'benchmark:' from the dataset name and add .csv suffix.
Expand Down Expand Up @@ -105,9 +85,6 @@ def execute(self, argv): # noqa
if args.state_file is None:
raise ValueError("Specify project file name (with .asreview extension).")

# print intro message
print(ASCII_LOGO + ASCII_MSG_SIMULATE)

# for webapp
if args.dataset == "":
project = ASReviewProject(args.state_file)
Expand Down