Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Node.js to version 20 #1538

Merged
merged 1 commit into from
Oct 12, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci-frontend.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
python-version: "3.10"
- uses: actions/setup-node@v3
with:
node-version: '16'
node-version: '20'
cache: 'npm'
cache-dependency-path: 'asreview/webapp/package-lock.json'
- name : Get Tags
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pythonpackage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
pip install setuptools wheel
- uses: actions/setup-node@v3
with:
node-version: '16'
node-version: '20'
cache: 'npm'
cache-dependency-path: 'asreview/webapp/package-lock.json'
- name: Compile assets
Expand Down
3 changes: 2 additions & 1 deletion DEVELOPMENT.md
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,8 @@ flake8 .

### Front end

Install both [npm][1] and Python
You need to install [Node.js](https://nodejs.org/en) for local development. We
use version 20.

Start the Python API server with the Flask development environment. Before the front end development can be started, the back end has to run as well

Expand Down