Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace R code by Notebook #13

Merged
merged 9 commits into from
Mar 13, 2020
Merged

Replace R code by Notebook #13

merged 9 commits into from
Mar 13, 2020

Conversation

terrymyc
Copy link
Member

No description provided.

@J535D165
Copy link
Member

J535D165 commented Mar 5, 2020

Thanks @terrymyc! Thanks for your contribution.

A couple of additions and remarks are listed below:

Exclude 4 more papers

~Based on the paper, the team excluded 4 more papers. 34 of the 38 papers were described in the paper. The papers listed below have to be excluded (isn't it? @Rensvandeschoot @GerbrichFerdinands ): ~

  • Sterling, M., Hendrikz, J., & Kenardy, J. (2010). Compensation claim lodgement and health outcome developmental trajectories following whiplash injury: A prospective study. Pain, 150(1), 22-28.
  • Hou, W. K., Law, C. C., Yin, J., & Fu, Y. T. (2010). Resource Loss, Resource Gain, and Psychological Resilience and Dysfunction Following Cancer Diagnosis: A Growth Mixture Modeling Approach. Health Psychology, 29(5), 484-495. doi:10.1037/a0020809
  • Mason, S. T., Corry, N., Gould, N. F., Amoyal, N., Gabriel, V., Wiechman-Askay, S., . . . Fauerbach, J. A. (2010). Growth curve trajectories of distress in burn patients. Journal of Burn Care and Research, 31(1), 64-72. doi:10.1097/BCR.0b013e3181cb8ee6
  • Pérez, S., Conchado, A., Andreu, Y., Galdón, M. J., Cardeña, E., Ibáñez, E., & Durá, E. (2016). Acute stress trajectories 1 year after a breast cancer diagnosis. Supportive Care in Cancer, 24(4), 1671-1678. doi:10.1007/s00520-015-2960-x

Connect to RIS files on OSF

The RIS files are now available on OSF. Can you connect them to your code and remove the ones in the Github repository?

Count duplicates

Thanks for your statistics so far. Can you count the number of duplicate items as well? Please don't make things too complicated, count check of duplicate abstracts for example.

It turns out that @qubixes is also doing some work on the dataset statistics. This is implemented in an extension for asreview https://github.com/asreview/asreview-statistics. It might be interesting to have a look. It would be nice to integrate the functionality with this repo (not for now).

@J535D165 J535D165 self-requested a review March 5, 2020 09:26
@terrymyc
Copy link
Member Author

terrymyc commented Mar 5, 2020

There is a discrepancy in the process between this dataset and Wilson dataset. For this dataset, 8 papers are directly included after abstract screening without full-text screening, whereas the Wilson dataset does not. So, the inclusion indicators are different in two datasets. Should we have a unified criteria for this?

@J535D165
Copy link
Member

J535D165 commented Mar 5, 2020

For this dataset, 8 papers are directly included after abstract screening without full-text screening

Good point. For now, I don't have an idea to unify this. I think we should consider these as "included after full-text reading", as we do in other datasets.

@J535D165
Copy link
Member

J535D165 commented Mar 5, 2020

@Rensvandeschoot decided to continue with the 38 inclusions. This means that the citation is incorrect. @GerbrichFerdinands can you drop the correct link to the paper here?

@J535D165
Copy link
Member

J535D165 commented Mar 5, 2020

This also means that the RIS files are stored in the wrong repository on OSF. @terrymyc, please wait till the files are moved to the correct repository. @Rensvandeschoot

Copy link
Member

@GerbrichFerdinands GerbrichFerdinands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Terry! ✨
Your code is very readable. I attached a few suggestions for improvement!

"# 62 with both missing titles and abstracts\n",
"print(\"Number of papers with missing title AND abstract: \", (all_title.isna() & all_data['abstract'].isna()).sum(), \"\\n\")\n",
"\n",
"# 764 with either missing titles or abstracts\n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get 766!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the statistics to summarize the missingness based on a clean dataset instead of dataset with duplicates. So, it becomes even less than 766.

@GerbrichFerdinands
Copy link
Member

GerbrichFerdinands commented Mar 8, 2020

@Rensvandeschoot decided to continue with the 38 inclusions. This means that the citation is incorrect. @GerbrichFerdinands can you drop the correct link to the paper here?

@J535D165

Rens van de Schoot, Marit Sijbrandij, Sonja D. Winter, Sarah Depaoli & Jeroen K. Vermunt (2017) The GRoLTS-Checklist: Guidelines for Reporting on Latent Trajectory Studies, Structural Equation Modeling: A Multidisciplinary Journal, 24:3, 451-467, DOI: 10.1080/10705511.2016.1247646

Copy link
Member

@J535D165 J535D165 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@terrymyc Can you update the citation?

@J535D165 J535D165 merged commit 16194fb into asreview:master Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants