Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server log game status needs "score" column removing or sanitising. #355

Closed
ac-jamz opened this issue May 24, 2021 · 4 comments
Closed

Server log game status needs "score" column removing or sanitising. #355

ac-jamz opened this issue May 24, 2021 · 4 comments
Assignees
@flowtron
Labels
Bugfix request Request to fix a bug.

Comments

@ac-jamz
Copy link
Contributor

ac-jamz commented May 24, 2021

image
@ac-jamz ac-jamz added the Bugfix request Request to fix a bug. label May 24, 2021
flowtron added a commit that referenced this issue May 24, 2021
@flowtron
server log game status w/o 'score' (fix #355)
9ae4213
@flowtron
Copy link
Contributor

fixed in commit 9ae4213a

@drian0 drian0 reopened this May 24, 2021
@drian0
Copy link
Contributor

drian0 commented May 24, 2021

@flowtron
Could you remove state.points altogether from the struct? This should not be used/referenced anymore I guess.

@flowtron
Copy link
Contributor

This is rather involved, there is a ton of stuff being done; e.g. regarding balancing teams that relies directly or indirectly on that value. We should chat about the details/implications before I commit something that breaks the game.

@drian0
Copy link
Contributor

drian0 commented May 25, 2021

Related to #269

flowtron added a commit that referenced this issue May 25, 2021
@flowtron
removing points from clientstate (issued #355 and #269)
3ea5bbf
@flowtron flowtron self-assigned this May 25, 2021
normal4 added a commit to normal4/AC that referenced this issue Jun 4, 2021
@normal4
Revert "removing points from clientstate (issued assaultcube#355 and a…
d9db732 
…ssaultcube#269)"

This reverts commit 3ea5bbf.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flowtron flowtron

Labels
Bugfix request Request to fix a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ac-jamz @flowtron @drian0