Remove check against index basename #47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
did you run all of the tests? doesn't appear so. this looks like it will break everything we described in the other issues I linked. |
|
I'd expect so. Just brought attention to the topic in the related ticket. |
|
At least running the default task on the PR succeeded, no failures. |
|
|
Unfortunately passing doesn't actually show if the file paths are mutated from expected behavior. I'll have to pull this down and run it in a little bit. thanks |
|
Thanks, that's what I just wanted to comment. It's a rough removal, I think you need to write a few more tests against the scenarios linked earlier. |
|
👍 |
|
I think it will broke other project configuration: permalinks: {
preset: 'pretty'
},
Result: |
|
I haven't had a chance to look yet, but I think this will require an option. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide PR for #46 research.